Introduce TsfEventRouter.

Introduce TsfEventRouter.

TsfEventRouter is used for catching tsf related events and forwarding to observers.
This class is not used at this moment. This will be used for implementing Omnibox suggestion on Metro UI.
This patch only affects on Metro UI and never affects on classic UI on Win8 or prior.

BUG=151901, 141820
TEST=Manually done on Win8 classic and metro mode.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162356

[Yohei Yukawa, 2012-10-15 06:55:45]

lgtm

[Seigo Nonaka, 2012-10-15 08:10:17]

Yukawa: Thank you for your review.

Adding sky@ as the owner of ui/

[sky, 2012-10-15 22:00:07]

http://codereview.chromium.org/11148012/diff/2001/ui/base/win/tsf_bridge.h
File ui/base/win/tsf_bridge.h (right):

http://codereview.chromium.org/11148012/diff/2001/ui/base/win/tsf_bridge.h#ne...
ui/base/win/tsf_bridge.h:10: #include "base/basictypes.h"
nit: newline between 9/10

http://codereview.chromium.org/11148012/diff/2001/ui/base/win/tsf_event_route...
File ui/base/win/tsf_event_router.cc (right):

http://codereview.chromium.org/11148012/diff/2001/ui/base/win/tsf_event_route...
ui/base/win/tsf_event_router.cc:10: #include "base/bind.h"
newline between 9/10.

http://codereview.chromium.org/11148012/diff/2001/ui/base/win/tsf_event_router.h
File ui/base/win/tsf_event_router.h (right):

http://codereview.chromium.org/11148012/diff/2001/ui/base/win/tsf_event_route...
ui/base/win/tsf_event_router.h:9: #include "base/basictypes.h"
newline between 8 and 9

http://codereview.chromium.org/11148012/diff/2001/ui/base/win/tsf_event_route...
ui/base/win/tsf_event_router.h:28: virtual ~TsfEventRouter();
nit: newline between 27/28.

http://codereview.chromium.org/11148012/diff/2001/ui/base/win/tsf_event_route...
ui/base/win/tsf_event_router.h:31: virtual void Associate(ITfThreadMgr* manager)
= 0;
Can you replace both Associate and EnsureDeassociated with SetManager() and have
it take NULL to deassociate?

[Seigo Nonaka, 2012-10-16 02:20:47]

http://codereview.chromium.org/11148012/diff/2001/ui/base/win/tsf_bridge.h
File ui/base/win/tsf_bridge.h (right):

http://codereview.chromium.org/11148012/diff/2001/ui/base/win/tsf_bridge.h#ne...
ui/base/win/tsf_bridge.h:10: #include "base/basictypes.h"
On 2012/10/15 22:00:07, sky wrote:
> nit: newline between 9/10

Done.

http://codereview.chromium.org/11148012/diff/2001/ui/base/win/tsf_event_route...
File ui/base/win/tsf_event_router.cc (right):

http://codereview.chromium.org/11148012/diff/2001/ui/base/win/tsf_event_route...
ui/base/win/tsf_event_router.cc:10: #include "base/bind.h"
On 2012/10/15 22:00:07, sky wrote:
> newline between 9/10.

Done.

http://codereview.chromium.org/11148012/diff/2001/ui/base/win/tsf_event_router.h
File ui/base/win/tsf_event_router.h (right):

http://codereview.chromium.org/11148012/diff/2001/ui/base/win/tsf_event_route...
ui/base/win/tsf_event_router.h:9: #include "base/basictypes.h"
On 2012/10/15 22:00:07, sky wrote:
> newline between 8 and 9

Done.

http://codereview.chromium.org/11148012/diff/2001/ui/base/win/tsf_event_route...
ui/base/win/tsf_event_router.h:28: virtual ~TsfEventRouter();
On 2012/10/15 22:00:07, sky wrote:
> nit: newline between 27/28.

Done.

http://codereview.chromium.org/11148012/diff/2001/ui/base/win/tsf_event_route...
ui/base/win/tsf_event_router.h:31: virtual void Associate(ITfThreadMgr* manager)
= 0;
On 2012/10/15 22:00:07, sky wrote:
> Can you replace both Associate and EnsureDeassociated with SetManager() and
have
> it take NULL to deassociate?

Done.

[sky, 2012-10-16 15:57:57]

LGTM - could we move the tsf code into a directory with you guys as OWNERs?

[Seigo Nonaka, 2012-10-16 17:26:56]

On 2012/10/16 15:57:57, sky wrote:
> LGTM - could we move the tsf code into a directory with you guys as OWNERs?

Sure, I will move to ui/base/ime.
Thanks.

[commit-bot: I haz the power, 2012-10-16 17:28:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nona@chromium.org/11148012/9001

[commit-bot: I haz the power, 2012-10-16 19:14:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nona@chromium.org/11148012/27002

[commit-bot: I haz the power, 2012-10-17 09:23:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nona@chromium.org/11148012/27002

[commit-bot: I haz the power, 2012-10-17 11:20:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nona@chromium.org/11148012/27002

[commit-bot: I haz the power, 2012-10-17 12:12:20]

Change committed as 162356