Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1477)

Unified Diff: chrome/browser/extensions/api/app_window/app_window_api.cc

Issue 11147037: Add a 'hidden' option to chrome.app.window.create() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix ash tests Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/app_window/app_window_api.cc
diff --git a/chrome/browser/extensions/api/app_window/app_window_api.cc b/chrome/browser/extensions/api/app_window/app_window_api.cc
index 34e855581da5ec160f0edbce45c32c6757d2c38b..6dfcafc12f45c04d6ec5e8d028ff8c6a501ce5c9 100644
--- a/chrome/browser/extensions/api/app_window/app_window_api.cc
+++ b/chrome/browser/extensions/api/app_window/app_window_api.cc
@@ -130,6 +130,9 @@ bool AppWindowCreateFunction::RunImpl() {
create_params.bounds.set_height(maximum_size.height());
if (create_params.bounds.height() < minimum_size.height())
create_params.bounds.set_height(minimum_size.height());
+
+ if (options->hidden.get())
+ create_params.hidden = *options->hidden.get();
}
create_params.creator_process_id =
@@ -137,7 +140,6 @@ bool AppWindowCreateFunction::RunImpl() {
ShellWindow* shell_window =
ShellWindow::Create(profile(), GetExtension(), url, create_params);
- shell_window->GetBaseWindow()->Show();
content::RenderViewHost* created_view =
shell_window->web_contents()->GetRenderViewHost();

Powered by Google App Engine
This is Rietveld 408576698