Fake video decoder in clearkey CDM.

Fake video decoder in clearkey CDM.

Add a fake video decoder that outputs colorful frames without really trying to decode the compressed buffers. This is useful for testing purpose.

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162267

[xhwang, 2012-10-15 20:54:50]

This is the fake video decoder I used for testing. I feel it's worth checking in
because it can be used for testing to isolate decoder related issues. 

The use of macro looks a little weird. If you have better ideas please do
comment!

PTAL!

[Tom Finegan, 2012-10-15 21:35:28]

lgtm % naming nit and this comment:

This seems like it should be defined as part of a test, but I can also see it
being useful where it is now.

http://codereview.chromium.org/11147032/diff/1/webkit/media/crypto/ppapi/clea...
File webkit/media/crypto/ppapi/clear_key_cdm.h (right):

http://codereview.chromium.org/11147032/diff/1/webkit/media/crypto/ppapi/clea...
webkit/media/crypto/ppapi/clear_key_cdm.h:116: #if
defined(CLEAR_KEY_CDM_USE_FAKE_DECODER)
CLEAR_KEY_CDM_USE_FAKE_VIDEO_DECODER

[xhwang, 2012-10-15 23:05:22]

nit fixed.

http://codereview.chromium.org/11147032/diff/1/webkit/media/crypto/ppapi/clea...
File webkit/media/crypto/ppapi/clear_key_cdm.h (right):

http://codereview.chromium.org/11147032/diff/1/webkit/media/crypto/ppapi/clea...
webkit/media/crypto/ppapi/clear_key_cdm.h:116: #if
defined(CLEAR_KEY_CDM_USE_FAKE_DECODER)
On 2012/10/15 21:35:28, Tom Finegan wrote:
> CLEAR_KEY_CDM_USE_FAKE_VIDEO_DECODER

Done.

[Tom Finegan, 2012-10-15 23:24:51]

lgtm

[commit-bot: I haz the power, 2012-10-16 19:38:48]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[ddorwin, 2012-10-16 19:49:39]

LGTM overall. I did not review the exact algorithms in the test function and
defer to Tom's review there.

[commit-bot: I haz the power, 2012-10-16 20:03:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xhwang@chromium.org/11147032/7

[commit-bot: I haz the power, 2012-10-16 22:18:46]

Change committed as 162267