Generate version resources for Chrome Frame using the same machinery as Chrome itself.

Generate version resources for Chrome Frame using the same machinery as Chrome itself.

Including generated files from within .rc files doesn't work since there's no dependency tracking going on.

BUG=155714
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162494

[robertshield, 2012-10-15 13:58:14]

https://chromiumcodereview.appspot.com/11147012/diff/8001/chrome/version.gypi
File chrome/version.gypi (right):

https://chromiumcodereview.appspot.com/11147012/diff/8001/chrome/version.gypi...
chrome/version.gypi:8: 'version_py_path':
'<(DEPTH)/chrome/tools/build/version.py',
I had heard that we weren't supposed to use DEPTH anymore. Is it necessary here?

https://chromiumcodereview.appspot.com/11147012/diff/8001/chrome_frame/npchro...
File chrome_frame/npchrome_frame_version.rc.version (right):

https://chromiumcodereview.appspot.com/11147012/diff/8001/chrome_frame/npchro...
chrome_frame/npchrome_frame_version.rc.version:29: // Note that Firefox 3.0
requires the charset to be 04e4 (multi-lingual).
> 80

https://chromiumcodereview.appspot.com/11147012/diff/8001/chrome_frame/npchro...
chrome_frame/npchrome_frame_version.rc.version:51: // Note that Firefox 3.0
requires the charset to be 1252 (multi-lingual).
> 80

[grt (UTC plus 2), 2012-10-15 14:43:24]

Thanks, Robert.  Comments addressed.

+joth for android_webview OWNERS approval
+sky for chrome OWNERS approval

Please redirect OWNERS approvals as desired/appropriate.  Thanks.

https://chromiumcodereview.appspot.com/11147012/diff/8001/chrome/version.gypi
File chrome/version.gypi (right):

https://chromiumcodereview.appspot.com/11147012/diff/8001/chrome/version.gypi...
chrome/version.gypi:8: 'version_py_path':
'<(DEPTH)/chrome/tools/build/version.py',
On 2012/10/15 13:58:14, robertshield wrote:
> I had heard that we weren't supposed to use DEPTH anymore. Is it necessary
here?

This .gypi file is now being included by .gyp files in different directories.  I
think DEPTH is needed to handle this.  DEPTH occurs many times in
build/common.gypi for the same reason, I believe.  Indeed, I just discovered
this from a thread on chromium-dev:

"When it does appear, it's within a GYPI file. This is intentional, due to how
pathname relativization/canonicalization happens with GYP includes - paths are
made relative to the including GYP, rather than to the (current) GYPI file,
therefore it's necessary to specify <(DEPTH) to ensure that, regardless of where
the including GYP file lives, the paths referenced are correct.

Even within GYPI, this is not a frequent thing - it's only for "utility GYPI"
files such as protoc or the Chrome for Android java helpers."

This is such a utility GYPI file that's intended to be included by GYP files
outside of this project.

https://chromiumcodereview.appspot.com/11147012/diff/8001/chrome_frame/npchro...
File chrome_frame/npchrome_frame_version.rc.version (right):

https://chromiumcodereview.appspot.com/11147012/diff/8001/chrome_frame/npchro...
chrome_frame/npchrome_frame_version.rc.version:29: // Note that Firefox 3.0
requires the charset to be 04e4 (multi-lingual).
On 2012/10/15 13:58:14, robertshield wrote:
> > 80

Done.

https://chromiumcodereview.appspot.com/11147012/diff/8001/chrome_frame/npchro...
chrome_frame/npchrome_frame_version.rc.version:51: // Note that Firefox 3.0
requires the charset to be 1252 (multi-lingual).
On 2012/10/15 13:58:14, robertshield wrote:
> > 80

Done.

[Torne, 2012-10-15 14:45:40]

android_webview LGTM

[grt (UTC plus 2), 2012-10-15 15:01:55]

-sky, +jhawkins for chrome OWNERS approval

[robertshield, 2012-10-16 14:18:21]

lgtm

lgtm

[robertshield, 2012-10-16 14:18:21]

lgtm

[sky, 2012-10-16 15:57:16]

Assuming you get Mark to review this: LGTM

[grt (UTC plus 2), 2012-10-16 16:01:50]

-jhawkins, +mentovai

Hi Mark, would you please have a look at this GYP magic?  The idea is to let
Chrome Frame (and eventually remoting) re-use Chrome's GYP rule for generating a
Windows .rc file containing version, copyright, and other info.  A follow-on CL
can convert remoting.gyp to use this.  Thanks.

[Nico, 2012-10-17 17:19:23]

On 2012/10/16 16:01:50, grt wrote:
> -jhawkins, +mentovai
> 
> Hi Mark, would you please have a look at this GYP magic?  The idea is to let
> Chrome Frame (and eventually remoting) re-use Chrome's GYP rule for generating
a
> Windows .rc file containing version, copyright, and other info.  A follow-on
CL
> can convert remoting.gyp to use this.  Thanks.

<mark-impersonation>The gypi changes lgtm. Just make sure to not say "we" in
comments.</mark-impersonation>

[commit-bot: I haz the power, 2012-10-17 17:33:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grt@chromium.org/11147012/19001

[commit-bot: I haz the power, 2012-10-17 19:50:24]

Change committed as 162494