Update EventExecutorLinux to use mouse wheel deltas if present.

Update EventExecutorLinux to use mouse wheel deltas if present.

BUG=145875
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162409

[Wez, 2012-10-13 01:02:54]

PTAL

We're replacing the current "ticks" wheel values with pixel-based "deltas" in
the Chromoting protocol; this is the backward-compatible Linux injector code.

[garykac, 2012-10-13 01:46:27]

http://codereview.chromium.org/11147009/diff/1/remoting/host/event_executor_l...
File remoting/host/event_executor_linux.cc (right):

http://codereview.chromium.org/11147009/diff/1/remoting/host/event_executor_l...
remoting/host/event_executor_linux.cc:37: const float kWheelTicksPerPixel = 3.0f
/ 160.0f;
nit: Add // From Source/WebKit/chromium/src/gtk/WebInputFactory.cc.

http://codereview.chromium.org/11147009/diff/1/remoting/host/event_executor_l...
remoting/host/event_executor_linux.cc:276: wheel_ticks_y_ +=
event.wheel_delta_y() * kWheelTicksPerPixel;
Since we're using floats, do we need to be concerned about wheel_ticks_y_ =
0.99999 not firing a wheel event (when it probably should)?

[Wez, 2012-10-13 02:50:45]

http://codereview.chromium.org/11147009/diff/1/remoting/host/event_executor_l...
File remoting/host/event_executor_linux.cc (right):

http://codereview.chromium.org/11147009/diff/1/remoting/host/event_executor_l...
remoting/host/event_executor_linux.cc:37: const float kWheelTicksPerPixel = 3.0f
/ 160.0f;
On 2012/10/13 01:46:28, garykac wrote:
> nit: Add // From Source/WebKit/chromium/src/gtk/WebInputFactory.cc.

Done.

http://codereview.chromium.org/11147009/diff/1/remoting/host/event_executor_l...
remoting/host/event_executor_linux.cc:276: wheel_ticks_y_ +=
event.wheel_delta_y() * kWheelTicksPerPixel;
On 2012/10/13 01:46:28, garykac wrote:
> Since we're using floats, do we need to be concerned about wheel_ticks_y_ =
> 0.99999 not firing a wheel event (when it probably should)?

That sounds like a good improvement for a future CL to me. :)

[Wez, 2012-10-16 04:35:04]

On 2012/10/13 02:50:45, Wez wrote:
>
http://codereview.chromium.org/11147009/diff/1/remoting/host/event_executor_l...
> File remoting/host/event_executor_linux.cc (right):
> 
>
http://codereview.chromium.org/11147009/diff/1/remoting/host/event_executor_l...
> remoting/host/event_executor_linux.cc:37: const float kWheelTicksPerPixel =
3.0f
> / 160.0f;
> On 2012/10/13 01:46:28, garykac wrote:
> > nit: Add // From Source/WebKit/chromium/src/gtk/WebInputFactory.cc.
> 
> Done.
> 
>
http://codereview.chromium.org/11147009/diff/1/remoting/host/event_executor_l...
> remoting/host/event_executor_linux.cc:276: wheel_ticks_y_ +=
> event.wheel_delta_y() * kWheelTicksPerPixel;
> On 2012/10/13 01:46:28, garykac wrote:
> > Since we're using floats, do we need to be concerned about wheel_ticks_y_ =
> > 0.99999 not firing a wheel event (when it probably should)?
> 
> That sounds like a good improvement for a future CL to me. :)

Ping!

[garykac, 2012-10-17 00:19:23]

lgtm

[commit-bot: I haz the power, 2012-10-17 00:27:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/11147009/4001

[commit-bot: I haz the power, 2012-10-17 11:16:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/11147009/4001

[commit-bot: I haz the power, 2012-10-17 15:11:31]

Change committed as 162409