Issue 11147004: use CXX compiler for c++ files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11147004: use CXX compiler for c++ files (Closed)

Created:
8 years, 2 months ago by Sam Clegg

Modified:
8 years, 2 months ago

Reviewers:
noelallen1, binji

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

use CXX compiler for c++ files. And enable warnings as errors on windows. Remove --std=gnu++98 since it is the default (and up until now not used). BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161736

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : feedback #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -12 lines)			Patch
M	native_client_sdk/src/build_tools/make_rules.py	View	1	7 chunks	+15 lines, -12 lines	0 comments	Download
M	native_client_sdk/src/examples/file_histogram/file_histogram.cc	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	native_client_sdk/src/examples/geturl/geturl_handler.cc	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	native_client_sdk/src/examples/mouselock/mouselock.h	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

binji

lgtm http://codereview.chromium.org/11147004/diff/2001/native_client_sdk/src/examples/file_histogram/file_histogram.cc File native_client_sdk/src/examples/file_histogram/file_histogram.cc (right): http://codereview.chromium.org/11147004/diff/2001/native_client_sdk/src/examples/file_histogram/file_histogram.cc#newcode45 native_client_sdk/src/examples/file_histogram/file_histogram.cc:45: #ifdef _MSC_VER let's be consistent about whether we ...

8 years, 2 months ago (2012-10-12 23:05:59 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sbc@chromium.org/11147004/2002

8 years, 2 months ago (2012-10-12 23:28:48 UTC) #3

Change committed as 161736

Expand Messages | Collapse Messages