Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 11146028: Mark Chrome OS default apps as WAS_INSTALLED_BY_DEFAULT. (Closed)

Created:
8 years, 2 months ago by Mihai Parparita -not on Chrome
Modified:
8 years, 2 months ago
Reviewers:
Dmitry Polukhin
CC:
chromium-reviews, Lei Zhang, Aaron Boodman, mihaip-chromium-reviews_chromium.org, Gaurav, Munjal (Google)
Visibility:
Public.

Description

Mark Chrome OS default apps as WAS_INSTALLED_BY_DEFAULT. This flag was added by r153554 and only set for desktop Chrome default apps. Since it affects install behavior (e.g. OAuth scope granting in ExtensionService::InitializePermissions) it should be set everywhere. BUG=156001 R=dpolukhin@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162257

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/extensions/external_provider_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Mihai Parparita -not on Chrome
8 years, 2 months ago (2012-10-16 01:08:16 UTC) #1
Mihai Parparita -not on Chrome
I would appreciate pointers for how to test this (or if you can patch it ...
8 years, 2 months ago (2012-10-16 01:09:25 UTC) #2
Dmitry Polukhin
LGTM You can test it on Linux machine by building Chrome with GYP_DEFINES="chromeos=1" and putting ...
8 years, 2 months ago (2012-10-16 10:27:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mihaip@chromium.org/11146028/1
8 years, 2 months ago (2012-10-16 18:14:57 UTC) #4
commit-bot: I haz the power
8 years, 2 months ago (2012-10-16 21:40:21 UTC) #5
Change committed as 162257

Powered by Google App Engine
This is Rietveld 408576698