Issue 11146011: fix Screen leak in ash tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11146011: fix Screen leak in ash tests (Closed)

Created:
8 years, 2 months ago by scottmg

Modified:
8 years, 2 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

fix Screen leak in ash tests valgrind memory fyi here: http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%284%29/builds/14345/steps/memory%20test%3A%20unit/logs/stdio TBR=ben@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161829

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	ash/shell.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	ash/shell.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/11146011/1

8 years, 2 months ago (2012-10-15 04:27:57 UTC) #2

Ben Goodger (Google)

8 years, 2 months ago (2012-10-15 16:47:17 UTC) #4

lgtm


On Sun, Oct 14, 2012 at 11:31 PM, <commit-bot@chromium.org> wrote:

> Change committed as 161829
>
>
https://chromiumcodereview.**appspot.com/11146011/<https://chromiumcodereview...
>

Expand Messages | Collapse Messages