Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 11145019: Establishing base/prefs. (Closed)

Created:
8 years, 2 months ago by Jói
Modified:
8 years, 2 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Establishing base/prefs. Same OWNERS as chrome/browser/prefs, plus joi@ for the refactoring work needed to break dependencies after the initial move. BUG=155525 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163270

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
A + base/prefs/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jói
mnissler: For OWNERS file review. brettw: For base/OWNERS, as previously discussed. Initially, code will move ...
8 years, 2 months ago (2012-10-15 12:00:09 UTC) #1
brettw
lgtm
8 years, 2 months ago (2012-10-19 21:20:46 UTC) #2
Mattias Nissler (ping if slow)
LGTM too.
8 years, 2 months ago (2012-10-22 07:53:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/11145019/1
8 years, 2 months ago (2012-10-22 11:14:31 UTC) #4
commit-bot: I haz the power
8 years, 2 months ago (2012-10-22 13:13:36 UTC) #5
Change committed as 163270

Powered by Google App Engine
This is Rietveld 408576698