Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 11145017: Invalidate the enum cache when converting a transition across which the descriptors are shared. (Closed)

Created:
8 years, 2 months ago by Toon Verwaest
Modified:
8 years, 2 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Invalidate the enum cache when converting a transition across which the descriptors are shared. Committed: https://code.google.com/p/v8/source/detail?r=12722

Patch Set 1 #

Patch Set 2 : Adding regression test #

Patch Set 3 : Remove expose-gc dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -8 lines) Patch
M src/objects.cc View 2 chunks +1 line, -3 lines 0 comments Download
A + test/mjsunit/regress/regress-convert-enum2.js View 1 2 1 chunk +18 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Toon Verwaest
PTAL.
8 years, 2 months ago (2012-10-15 07:52:44 UTC) #1
Jakob Kummerow
The change LGTM. How about a regression test?
8 years, 2 months ago (2012-10-15 07:54:33 UTC) #2
Toon Verwaest
Added regression test
8 years, 2 months ago (2012-10-15 08:36:36 UTC) #3
Jakob Kummerow
8 years, 2 months ago (2012-10-15 08:37:19 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698