Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 11145002: Remove more tests from the NaCl SCons build. (Closed)

Created:
8 years, 2 months ago by Nick Bray (chromium)
Modified:
8 years, 2 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Remove more tests from the NaCl SCons build. * pnacl_test_example was a smoke test that broke in revision r161425. * browser_startup_time was a performance test that needs to be redone to work on the Chrome bots. * stress_many_nexes was a manual test. BUG= http://code.google.com/p/chromium/issues/detail?id=154400 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162173

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 2

Patch Set 3 : Fix bad test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -485 lines) Patch
M ppapi/native_client/chrome_main.scons View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/native_client/ppapi_scons_files.py View 1 chunk +0 lines, -1 line 0 comments Download
D ppapi/native_client/tests/nacl_browser/browser_startup_time/browser_startup_time.html View 1 chunk +0 lines, -23 lines 0 comments Download
D ppapi/native_client/tests/nacl_browser/browser_startup_time/browser_startup_time.js View 1 chunk +0 lines, -46 lines 0 comments Download
D ppapi/native_client/tests/nacl_browser/browser_startup_time/hello_world.cc View 1 chunk +0 lines, -62 lines 0 comments Download
D ppapi/native_client/tests/nacl_browser/browser_startup_time/nacl.scons View 1 chunk +0 lines, -73 lines 0 comments Download
M ppapi/native_client/tests/nacl_browser/pnacl_client_translator/nacl.scons View 1 2 3 chunks +3 lines, -45 lines 0 comments Download
M ppapi/native_client/tests/nacl_browser/pnacl_client_translator/pnacl_bad_pexe_undefined_syms.nmf View 1 2 1 chunk +1 line, -1 line 0 comments Download
D ppapi/native_client/tests/nacl_browser/pnacl_client_translator/pnacl_test_example.html View 1 chunk +0 lines, -108 lines 0 comments Download
A + ppapi/native_client/tests/nacl_browser/pnacl_client_translator/program_fragment.cc View 1 2 1 chunk +5 lines, -2 lines 0 comments Download
D ppapi/native_client/tests/ppapi_browser/stress_many_nexes/nacl.scons View 1 chunk +0 lines, -36 lines 0 comments Download
D ppapi/native_client/tests/ppapi_browser/stress_many_nexes/stress_many_nexes.html View 1 chunk +0 lines, -87 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Nick Bray (chromium)
8 years, 2 months ago (2012-10-12 21:39:06 UTC) #1
Mark Seaborn
LGTM when the bots pass https://codereview.chromium.org/11145002/diff/12/ppapi/native_client/tests/nacl_browser/browser_startup_time/nacl.scons File ppapi/native_client/tests/nacl_browser/browser_startup_time/nacl.scons (left): https://codereview.chromium.org/11145002/diff/12/ppapi/native_client/tests/nacl_browser/browser_startup_time/nacl.scons#oldcode25 ppapi/native_client/tests/nacl_browser/browser_startup_time/nacl.scons:25: '${SCONSTRUCT_DIR}/tools/process_perf_output.py')), Will you also ...
8 years, 2 months ago (2012-10-12 22:00:48 UTC) #2
jvoung - send to chromium...
https://codereview.chromium.org/11145002/diff/12/ppapi/native_client/tests/nacl_browser/pnacl_client_translator/nacl.scons File ppapi/native_client/tests/nacl_browser/pnacl_client_translator/nacl.scons (right): https://codereview.chromium.org/11145002/diff/12/ppapi/native_client/tests/nacl_browser/pnacl_client_translator/nacl.scons#newcode41 ppapi/native_client/tests/nacl_browser/pnacl_client_translator/nacl.scons:41: 'pnacl_test_example_obj.bc', You can substitute a fairly arbitrary .bc file ...
8 years, 2 months ago (2012-10-12 23:37:06 UTC) #3
Nick Bray
PTAL, the bots are being pretty slow but I tested the fix locally. I added ...
8 years, 2 months ago (2012-10-15 23:22:38 UTC) #4
jvoung (off chromium)
LGTM thanks!
8 years, 2 months ago (2012-10-15 23:28:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ncbray@chromium.org/11145002/12002
8 years, 2 months ago (2012-10-16 15:59:09 UTC) #6
commit-bot: I haz the power
8 years, 2 months ago (2012-10-16 18:09:22 UTC) #7
Change committed as 162173

Powered by Google App Engine
This is Rietveld 408576698