Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Issue 11144010: Add a using declaration for Timer::Start in BaseTimerMethodPointer. (Closed)

Created:
8 years, 2 months ago by tim (not reviewing)
Modified:
8 years, 2 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Add a using declaration for Timer::Start in BaseTimerMethodPointer. This is to get around the fact that Timer::Start, which has a friendlier base::Closure signature, is hidden by BaseTimerMethodPointer::Start. BUG=148832 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163186

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M base/timer.h View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tim (not reviewing)
Hi Will, can you review this? I realize this makes it easier to procrastinate cleaning ...
8 years, 2 months ago (2012-10-13 20:03:50 UTC) #1
willchan no longer on Chromium
I'm going to shut my eyes, close my nose, and approve this CL. LGTM.
8 years, 2 months ago (2012-10-17 20:01:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tim@chromium.org/11144010/1
8 years, 2 months ago (2012-10-17 23:37:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tim@chromium.org/11144010/1
8 years, 2 months ago (2012-10-19 17:03:52 UTC) #4
commit-bot: I haz the power
8 years, 2 months ago (2012-10-20 21:03:08 UTC) #5
Change committed as 163186

Powered by Google App Engine
This is Rietveld 408576698