Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Issue 11143028: Change GetFontListAsync() to use the blocking pool. (Closed)

Created:
8 years, 2 months ago by yzshen1
Modified:
8 years, 2 months ago
Reviewers:
brettw
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Change GetFontListAsync() to use the blocking pool. PPB_Font_Dev.GetFontFamilies() is a sync operation that waits for GetFontListAsync() to finish on the FILE thread in the browser process. If the thread is busy, it could hang for quite a while. Some Pepper Flash hangs are caused by this. BUG=155931 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162383

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M content/browser/font_list_async.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yzshen1
Hi, Brett. Would you please take a look? Thanks!
8 years, 2 months ago (2012-10-15 22:48:06 UTC) #1
brettw
lgtm
8 years, 2 months ago (2012-10-16 23:19:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/11143028/1
8 years, 2 months ago (2012-10-16 23:21:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/11143028/1
8 years, 2 months ago (2012-10-17 11:15:50 UTC) #4
commit-bot: I haz the power
8 years, 2 months ago (2012-10-17 13:22:19 UTC) #5
Change committed as 162383

Powered by Google App Engine
This is Rietveld 408576698