Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 11143002: Don't hang if can't downsize font. (Closed)

Created:
8 years, 2 months ago by Vitaly Buka (NO REVIEWS)
Modified:
8 years, 2 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Don't hang if can't downsize font. BUG=152889 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161704

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M ui/gfx/platform_font_win.cc View 1 chunk +7 lines, -1 line 0 comments Download
M ui/gfx/platform_font_win_unittest.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Vitaly Buka (NO REVIEWS)
8 years, 2 months ago (2012-10-12 21:25:51 UTC) #1
msw
Can you add a test for the case that was failing?
8 years, 2 months ago (2012-10-12 21:30:58 UTC) #2
Vitaly Buka (NO REVIEWS)
On 2012/10/12 21:30:58, msw wrote: > Can you add a test for the case that ...
8 years, 2 months ago (2012-10-12 21:52:43 UTC) #3
msw
Fantastic! LGTM; thank you.
8 years, 2 months ago (2012-10-12 21:55:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/11143002/3001
8 years, 2 months ago (2012-10-12 22:17:26 UTC) #5
commit-bot: I haz the power
8 years, 2 months ago (2012-10-13 03:47:26 UTC) #6
Change committed as 161704

Powered by Google App Engine
This is Rietveld 408576698