Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 11142010: Specify a file size limit for minidumps (Closed)

Created:
8 years, 2 months ago by Michael Krebs
Modified:
8 years, 1 month ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Visibility:
Public.

Description

Specify a file size limit for minidumps When there are upwards of 200 threads in a crashing process, each having an 8KB stack, this can result in a huge, 1.8MB minidump file. The Crash Server throws away any uploaded file larger than 1.2MB. Setting the minidump size limit (see https://breakpad.appspot.com/487002/) will result in less stack being dumped when there are so many threads. BUG=chromium-os:31447, chromium:154546 Contributed by Michael Krebs <mkrebs@chromium.org>; Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169221

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M chrome/app/breakpad_linux.h View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/app/breakpad_linux.cc View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/crash_handler_host_linux.cc View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Michael Krebs
Note, this CL can't be committed until https://breakpad.appspot.com/487002/ is committed and included in Chrome's Breakpad. ...
8 years, 2 months ago (2012-10-13 05:58:33 UTC) #1
Michael Krebs
Lei, with the corresponding Breakpad changes in now, would you be able to take a ...
8 years, 1 month ago (2012-11-16 01:37:49 UTC) #2
Lei Zhang
lgtm If it builds for you locally with breakpad turned on, that's good enough. Let ...
8 years, 1 month ago (2012-11-16 21:18:15 UTC) #3
Michael Krebs
It builds now in my local checkout. So it should be ready to commit.
8 years, 1 month ago (2012-11-22 02:34:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkrebs@chromium.org/11142010/14001
8 years, 1 month ago (2012-11-22 02:55:58 UTC) #5
commit-bot: I haz the power
8 years, 1 month ago (2012-11-22 04:54:45 UTC) #6
Change committed as 169221

Powered by Google App Engine
This is Rietveld 408576698