chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc - Issue 11141037: Disable delegation to picker controller once it is deleted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc

Issue 11141037: Disable delegation to picker controller once it is deleted. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase, fix tests. Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/intents/web_intent_picker_controller.cc ('k') | chrome/browser/ui/views/web_intent_picker_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc

diff --git a/chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc b/chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc

index 16fe332a0dc573f0424927778c1f2bb59b23abe8..e8f51401bfd8868e5087629186a57dcb2c09f657 100644

--- a/chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc

+++ b/chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc

@@ -129,6 +129,9 @@ class WebIntentPickerMock : public WebIntentPicker,

virtual void OnPendingAsyncCompleted() OVERRIDE {

StopWaiting();

}

+ virtual void InvalidateDelegate() OVERRIDE {

+ delegate_ = NULL;

+ }

// WebIntentPickerModelObserver implementation.

virtual void OnModelChanged(WebIntentPickerModel* model) OVERRIDE {

« no previous file with comments | « chrome/browser/ui/intents/web_intent_picker_controller.cc ('k') | chrome/browser/ui/views/web_intent_picker_views.cc » ('j') | no next file with comments »