DevTools: [remote debugging] terminate web socket connection upon renderer disconnect.

DevTools: [remote debugging] terminate web socket connection upon renderer disconnect.

BUG=154253
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162123

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162355

[yurys, 2012-10-16 06:18:20]

http://codereview.chromium.org/11141024/diff/3002/content/browser/debugger/de...
File content/browser/debugger/devtools_http_handler_impl.cc (right):

http://codereview.chromium.org/11141024/diff/3002/content/browser/debugger/de...
content/browser/debugger/devtools_http_handler_impl.cc:100: registrar_.Add(this,
NOTIFICATION_RENDERER_PROCESS_CLOSED,
We listen to the termination of the render process which will happen only when
the last render view in that process is gone. But there may be render views in
other processes, don't we want to be able to inspect them?

http://codereview.chromium.org/11141024/diff/3002/content/browser/debugger/de...
content/browser/debugger/devtools_http_handler_impl.cc:511: rvh->GetProcess());
This will not work for clients attached to instances without RVH, e.g. for
workers. Can we provide a generic mechanism that would allow clients to listen
for the agent termiation?

[pfeldman, 2012-10-16 08:35:28]

http://codereview.chromium.org/11141024/diff/3002/content/browser/debugger/de...
File content/browser/debugger/devtools_http_handler_impl.cc (right):

http://codereview.chromium.org/11141024/diff/3002/content/browser/debugger/de...
content/browser/debugger/devtools_http_handler_impl.cc:100: registrar_.Add(this,
NOTIFICATION_RENDERER_PROCESS_CLOSED,
We maintain WebSocket connection (And DevToolsClientHostImpl) per RVH. When the
process dies, all RVHs belonging to that process will disconnect. That's exactly
what I am trying to achieve.

http://codereview.chromium.org/11141024/diff/3002/content/browser/debugger/de...
content/browser/debugger/devtools_http_handler_impl.cc:511: rvh->GetProcess());
Allowing workers will require a major rewrite of discovery code in this class
anyways.

[yurys, 2012-10-16 08:52:36]

lgtm

[pfeldman, 2012-10-16 09:09:39]

lgtm

[commit-bot: I haz the power, 2012-10-16 09:09:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pfeldman@chromium.org/11141024/3002

[commit-bot: I haz the power, 2012-10-16 11:23:29]

Change committed as 162123

[yurys, 2012-10-17 10:05:06]

lgtm

[commit-bot: I haz the power, 2012-10-17 10:11:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pfeldman@chromium.org/11141024/28001

[commit-bot: I haz the power, 2012-10-17 12:11:04]

Change committed as 162355