Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 11141022: Ensure proper wrapping of controlled setting indicators (Closed)

Created:
8 years, 2 months ago by bartfab (slow)
Modified:
8 years, 2 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, arv (Not doing code reviews), stevenjb+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Ensure proper wrapping of controlled setting indicators Controlled setting indicators usually appear next to input elements. When space gets tight and the input element's label wraps over multiple lines, the indicator gets misplaced instead of wrapping with the label. This CL makes sure that the label and the controlled setting indicator are inline elements within the same box so that they wrap around together. TEST=Change options page CSS to force wrapping, check visual appearance BUG=104955 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162746

Patch Set 1 #

Patch Set 2 : Modified element nesting so that controlled setting indicators are not children of a label. #

Total comments: 2

Patch Set 3 : Comment addressed. #

Patch Set 4 : Whitespace fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -57 lines) Patch
M chrome/browser/resources/options/browser_options.css View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/chromeos/internet_detail.css View 1 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/chromeos/internet_detail.html View 1 2 3 5 chunks +59 lines, -30 lines 0 comments Download
M chrome/browser/resources/options/home_page_overlay.css View 1 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/resources/options/home_page_overlay.html View 1 2 3 1 chunk +27 lines, -21 lines 0 comments Download
M chrome/browser/resources/options/options_page.css View 1 2 2 chunks +26 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
bartfab (slow)
Hi James, could you have a look?
8 years, 2 months ago (2012-10-15 10:53:26 UTC) #1
bartfab (slow)
I had to redo the HTML element nesting. Making the controlled setting indicator a child ...
8 years, 2 months ago (2012-10-15 23:05:47 UTC) #2
James Hawkins
https://chromiumcodereview.appspot.com/11141022/diff/3001/chrome/browser/resources/options/chromeos/internet_detail.html File chrome/browser/resources/options/chromeos/internet_detail.html (right): https://chromiumcodereview.appspot.com/11141022/diff/3001/chrome/browser/resources/options/chromeos/internet_detail.html#newcode74 chrome/browser/resources/options/chromeos/internet_detail.html:74: <label for="prefer-network-wifi"> Just set i18n-content of the label element.
8 years, 2 months ago (2012-10-17 03:35:37 UTC) #3
bartfab (slow)
https://codereview.chromium.org/11141022/diff/3001/chrome/browser/resources/options/chromeos/internet_detail.html File chrome/browser/resources/options/chromeos/internet_detail.html (right): https://codereview.chromium.org/11141022/diff/3001/chrome/browser/resources/options/chromeos/internet_detail.html#newcode74 chrome/browser/resources/options/chromeos/internet_detail.html:74: <label for="prefer-network-wifi"> On 2012/10/17 03:35:37, James Hawkins wrote: > ...
8 years, 2 months ago (2012-10-18 12:39:53 UTC) #4
James Hawkins
lgtm
8 years, 2 months ago (2012-10-18 16:33:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/11141022/10002
8 years, 2 months ago (2012-10-18 16:40:09 UTC) #6
commit-bot: I haz the power
8 years, 2 months ago (2012-10-18 18:41:23 UTC) #7
Change committed as 162746

Powered by Google App Engine
This is Rietveld 408576698