Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11141008: Roll libjingle to r204 (Closed)

Created:
8 years, 2 months ago by Alpha Left Google
Modified:
8 years, 2 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Roll libjingle to r204 Rolling 203:204 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161999

Patch Set 1 #

Patch Set 2 : fixed compilation errors #

Patch Set 3 : #

Patch Set 4 : unhappy overrides #

Total comments: 2

Patch Set 5 : more changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -10 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/mock_media_stream_dependency_factory.h View 1 2 3 4 4 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/mock_media_stream_dependency_factory.cc View 1 2 3 4 3 chunks +6 lines, -6 lines 0 comments Download
M content/renderer/media/mock_peer_connection_impl.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/media/mock_peer_connection_impl.cc View 1 1 chunk +14 lines, -0 lines 0 comments Download
M content/renderer/media/rtc_video_capturer.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/rtc_video_capturer.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/media/rtc_video_decoder_unittest.cc View 1 3 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/libjingle/README.chromium View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Alpha Left Google
8 years, 2 months ago (2012-10-13 03:18:17 UTC) #1
Ronghua Wu (Left Chromium)
Please also update the third_party/libjingle/README.chromium. There're few more interface changes that requires updating the glue ...
8 years, 2 months ago (2012-10-14 23:55:54 UTC) #2
Ronghua Wu (Left Chromium)
LGTM with comments and don't forget to update third_party/libjingle/README.chromium. You still need approval from wjia. ...
8 years, 2 months ago (2012-10-15 16:07:47 UTC) #3
wjia(left Chromium)
owner's stamp, lgtm after ronghuawu@'s comment is addressed.
8 years, 2 months ago (2012-10-15 16:30:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/11141008/14009
8 years, 2 months ago (2012-10-15 20:27:25 UTC) #5
commit-bot: I haz the power
8 years, 2 months ago (2012-10-15 23:31:20 UTC) #6 
Change committed as 161999

Powered by Google App Engine
This is Rietveld 408576698