lib/compiler/implementation/elements/elements.dart - Issue 11140018: Ensure that ClassElement.lookupConstructor fails when looking up default constructor using Selector…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/elements/elements.dart

Issue 11140018: Ensure that ClassElement.lookupConstructor fails when looking up default constructor using Selector… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Use [==] and [!=] instead of [identical] for SourceString comparison. Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/compiler/implementation/elements/elements.dart

diff --git a/lib/compiler/implementation/elements/elements.dart b/lib/compiler/implementation/elements/elements.dart

index 8eb26d8a00f392d4332016bb66bbed4bbe3d6143..1fcdac5f801818bf7f0c697b3b3d9bd6fba9649d 100644

--- a/lib/compiler/implementation/elements/elements.dart

+++ b/lib/compiler/implementation/elements/elements.dart

@@ -1482,9 +1482,7 @@ abstract class ClassElement extends ScopeContainerElement

SourceString normalizedName;

SourceString className = this.name;

SourceString constructorName = selector.name;

- if (!identical(constructorName, const SourceString('')) &&

- ((className == null) ||

- (constructorName.slowToString() != className.slowToString()))) {

+ if (constructorName != const SourceString('')) {

normalizedName = Elements.constructConstructorName(className,

constructorName);

} else {

« no previous file with comments | « no previous file | lib/compiler/implementation/resolution/members.dart » ('j') | tests/compiler/dart2js/resolver_test.dart » ('J')