Ensure that ClassElement.lookupConstructor fails when looking up default constructor using Selector…

tests/compiler/dart2js/resolver_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:uri';
 
 import "../../../lib/compiler/implementation/dart2jslib.dart"
     hide TreeElementMapping, TreeElements;
 import "../../../lib/compiler/implementation/resolution/resolution.dart";
 import "../../../lib/compiler/implementation/elements/elements.dart";
@@ skipping 550 matching lines @@
 resolveConstructor(String script, String statement, String className,
                    String constructor, int expectedElementCount,
                    {List expectedWarnings: const [],
                     List expectedErrors: const [],
                     String corelib: DEFAULT_CORELIB}) {
   MockCompiler compiler = new MockCompiler(coreSource: corelib);
   compiler.parseScript(script);
   compiler.resolveStatement(statement);
   ClassElement classElement =
       compiler.mainApp.find(buildSourceString(className));
-  Element element =
-      classElement.lookupConstructor(
-          new Selector.callConstructor(buildSourceString(constructor),
-                                       classElement.getLibrary()));
+  Element element;
+  if (constructor !== '') {

[ahe, 2012/10/26 11:08:53]

!=

+    element = classElement.lookupConstructor(
+        new Selector.callConstructor(buildSourceString(constructor),
+                                     classElement.getLibrary()));
+  } else {
+    element = classElement.lookupConstructor(
+        new Selector.callDefaultConstructor(classElement.getLibrary()));
+  }
+
   FunctionExpression tree = element.parseNode(compiler);
   ResolverVisitor visitor =
       new ResolverVisitor(compiler, element,
                           new CollectingTreeElements(element));
   new InitializerResolver(visitor).resolveInitializers(element, tree);
   visitor.visit(tree.body);
   Expect.equals(expectedElementCount, map(visitor).length);
 
   compareWarningKinds(script, expectedWarnings, compiler.warnings);
   compareWarningKinds(script, expectedErrors, compiler.errors);
@@ skipping 38 matching lines @@
   Expect.equals(<String>['B', 'C', 'Object'].toString(),
                 asSortedStrings(supertypes).toString());
 }
 
 testInitializers() {
   String script;
   script = """class A {
                 int foo; int bar;
                 A() : this.foo = 1, bar = 2;
               }""";
-  resolveConstructor(script, "A a = new A();", "A", "A", 2);
+  resolveConstructor(script, "A a = new A();", "A", "", 2);
 
   script = """class A {
                 int foo; A a;
                 A() : a.foo = 1;
                 }""";
-  resolveConstructor(script, "A a = new A();", "A", "A", 0,
+  resolveConstructor(script, "A a = new A();", "A", "", 0,
                      expectedWarnings: [],
                      expectedErrors:
                          [MessageKind.INVALID_RECEIVER_IN_INITIALIZER]);
 
   script = """class A {
                 int foo;
                 A() : this.foo = 1, this.foo = 2;
               }""";
-  resolveConstructor(script, "A a = new A();", "A", "A", 2,
+  resolveConstructor(script, "A a = new A();", "A", "", 2,
                      expectedWarnings: [MessageKind.ALREADY_INITIALIZED],
                      expectedErrors: [MessageKind.DUPLICATE_INITIALIZER]);
 
   script = """class A {
                 A() : this.foo = 1;
               }""";
-  resolveConstructor(script, "A a = new A();", "A", "A", 0,
+  resolveConstructor(script, "A a = new A();", "A", "", 0,
                      expectedWarnings: [],
                      expectedErrors: [MessageKind.CANNOT_RESOLVE]);
 
   script = """class A {
                 int foo;
                 int bar;
                 A() : this.foo = bar;
               }""";
-  resolveConstructor(script, "A a = new A();", "A", "A", 3,
+  resolveConstructor(script, "A a = new A();", "A", "", 3,
                      expectedWarnings: [],
                      expectedErrors: [MessageKind.NO_INSTANCE_AVAILABLE]);
 
   script = """class A {
                 int foo() => 42;
                 A() : foo();
               }""";
-  resolveConstructor(script, "A a = new A();", "A", "A", 0,
+  resolveConstructor(script, "A a = new A();", "A", "", 0,
                      expectedWarnings: [],
                      expectedErrors: [MessageKind.CONSTRUCTOR_CALL_EXPECTED]);
 
   script = """class A {
                 int i;
                 A.a() : this.b(0);
                 A.b(int i);
               }""";
   resolveConstructor(script, "A a = new A.a();", "A", "a", 1);
 
   script = """class A {
                 int i;
                 A.a() : i = 42, this(0);
                 A(int i);
               }""";
   resolveConstructor(script, "A a = new A.a();", "A", "a", 2,
                      expectedWarnings: [],
                      expectedErrors:
                          [MessageKind.REDIRECTING_CONSTRUCTOR_HAS_INITIALIZER]);
 
   script = """class A {
                 int i;
                 A(i);
               }
               class B extends A {
                 B() : super(0);
               }""";
-  resolveConstructor(script, "B a = new B();", "B", "B", 1);
+  resolveConstructor(script, "B a = new B();", "B", "", 1);
 
   script = """class A {
                 int i;
                 A(i);
               }
               class B extends A {
                 B() : super(0), super(1);
               }""";
-  resolveConstructor(script, "B b = new B();", "B", "B", 2,
+  resolveConstructor(script, "B b = new B();", "B", "", 2,
                      expectedWarnings: [],
                      expectedErrors: [MessageKind.DUPLICATE_SUPER_INITIALIZER]);
 
   script = "";
   final String CORELIB_WITH_INVALID_OBJECT =
       '''print(var obj) {}
          class int {}
          class double {}
          class bool {}
          class String {}
          class num {}
          class Function {}
          class List {}
          class Map {}
          class Closure {}
          class Null {}
          class Dynamic_ {}
          class Object { Object() : super(); }''';
-  resolveConstructor(script, "Object o = new Object();", "Object", "Object", 1,
+  resolveConstructor(script, "Object o = new Object();", "Object", "", 1,
                      expectedWarnings: [],
                      expectedErrors: [MessageKind.SUPER_INITIALIZER_IN_OBJECT],
                      corelib: CORELIB_WITH_INVALID_OBJECT);
 }
 
 map(ResolverVisitor visitor) {
   TreeElementMapping elements = visitor.mapping;
   return elements.map;
 }
 
@@ skipping 61 matching lines @@
         var d = new D();
         --d;
       }""";
   final compiler = compileScript(script);
 
   checkMemberResolved(compiler, 'A', operatorName('+', false));
   checkMemberResolved(compiler, 'B', operatorName('+', false));
   checkMemberResolved(compiler, 'C', operatorName('-', false));
   checkMemberResolved(compiler, 'D', operatorName('-', false));
 }