Ensure that ClassElement.lookupConstructor fails when looking up default constructor using Selector…

lib/compiler/implementation/elements/elements.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library elements;
 
 import 'dart:uri';
 
 // TODO(ahe): Rename prefix to 'api' when VM bug is fixed.
 import '../../compiler.dart' as api_e;
@@ skipping 1464 matching lines @@
     return result;
   }
 
   // TODO(aprelev@gmail.com): Peter believes that it would be great to
   // make noMatch a required argument. Peter's suspicion is that most
   // callers of this method would benefit from using the noMatch method.
   Element lookupConstructor(Selector selector, [Element noMatch(Element)]) {
     SourceString normalizedName;
     SourceString className = this.name;
     SourceString constructorName = selector.name;
-    if (!identical(constructorName, const SourceString('')) &&

[ahe, 2012/10/26 04:39:10]

Actually, I think this should be ==, not identical. 

[aam-me, 2012/10/26 10:59:55]

Done.

-        ((className == null) ||
-         (constructorName.slowToString() != className.slowToString()))) {
+    if (!identical(constructorName, const SourceString(''))) {
       normalizedName = Elements.constructConstructorName(className,
                                                          constructorName);
     } else {
       normalizedName = className;
     }
     Element result = localLookup(normalizedName);
     return validateConstructorLookupResults(selector, result, noMatch);
   }
 
   Element lookupFactoryConstructor(Selector selector,
@@ skipping 435 matching lines @@
 
   MetadataAnnotation ensureResolved(Compiler compiler) {
     if (resolutionState == STATE_NOT_STARTED) {
       compiler.resolver.resolveMetadataAnnotation(this);
     }
     return this;
   }
 
   String toString() => 'MetadataAnnotation($value, $resolutionState)';
 }