Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1294)

Unified Diff: chrome/renderer/resources/extensions/browser_tag.js

Issue 11139005: Expose Browser Plugin API in <browser> Tag Shim. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/extensions/platform_apps/browser_tag/main.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/resources/extensions/browser_tag.js
diff --git a/chrome/renderer/resources/extensions/browser_tag.js b/chrome/renderer/resources/extensions/browser_tag.js
index 362ebea154313565dfbf0977853de2ced78ef992..3035257e36fbcd20e87a3f4e5f1246b8dba76dce 100644
--- a/chrome/renderer/resources/extensions/browser_tag.js
+++ b/chrome/renderer/resources/extensions/browser_tag.js
@@ -9,6 +9,20 @@
var BROWSER_TAG_ATTRIBUTES = ['src', 'width', 'height'];
+// All exposed api methods for <browser>, these are forwarded to the browser
+// plugin.
+var BROWSER_TAG_API_METHODS = [
+ 'addEventListener',
+ 'back',
+ 'forward',
+ 'getProcessId',
+ 'go',
+ 'reload',
+ 'removeEventListener',
+ 'stop',
+ 'terminate'
+ ];
+
window.addEventListener('DOMContentLoaded', function() {
// Handle <browser> tags already in the document.
var browserNodes = document.body.querySelectorAll('browser');
@@ -39,8 +53,15 @@ function BrowserTag(node) {
this.objectNode_ = document.createElement('object');
this.objectNode_.type = 'application/browser-plugin';
BROWSER_TAG_ATTRIBUTES.forEach(this.copyAttribute_, this);
+
shadowRoot.appendChild(this.objectNode_);
+ // this.objectNode_[apiMethod] are defined after the shadow object is appended
+ // to the shadow root.
+ BROWSER_TAG_API_METHODS.forEach(function(apiMethod) {
+ node[apiMethod] = this.objectNode_[apiMethod].bind(this.objectNode_);
+ }, this);
+
// Map attribute modifications on the <browser> tag to changes on the
// underlying <object> node.
var handleMutation = this.handleMutation_.bind(this);
« no previous file with comments | « no previous file | chrome/test/data/extensions/platform_apps/browser_tag/main.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698