Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: chrome/renderer/resources/extensions/browser_tag.js

Issue 11139005: Expose Browser Plugin API in <browser> Tag Shim. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/resources/extensions/browser_tag.js
diff --git a/chrome/renderer/resources/extensions/browser_tag.js b/chrome/renderer/resources/extensions/browser_tag.js
index 362ebea154313565dfbf0977853de2ced78ef992..0271532306a6ce3606e729a012fe0ab3f4891032 100644
--- a/chrome/renderer/resources/extensions/browser_tag.js
+++ b/chrome/renderer/resources/extensions/browser_tag.js
@@ -9,6 +9,20 @@
var BROWSER_TAG_ATTRIBUTES = ['src', 'width', 'height'];
+// All exposed api methods for <browser>, these are forwarded to the browser
+// plugin.
+var BROWSER_TAG_API_METHODS = [
+ 'addEventListener',
+ 'back',
+ 'forward',
+ 'getProcessId',
+ 'go',
+ 'reload',
+ 'removeEventListener',
+ 'stop',
+ 'terminate'
+ ];
+
window.addEventListener('DOMContentLoaded', function() {
// Handle <browser> tags already in the document.
var browserNodes = document.body.querySelectorAll('browser');
@@ -38,7 +52,13 @@ function BrowserTag(node) {
this.objectNode_ = document.createElement('object');
this.objectNode_.type = 'application/browser-plugin';
+ var objectNode = this.objectNode_;
BROWSER_TAG_ATTRIBUTES.forEach(this.copyAttribute_, this);
+ BROWSER_TAG_API_METHODS.forEach(function(apiMethod) {
+ node[apiMethod] = function(var_args) {
+ return objectNode[apiMethod].apply(objectNode, arguments);
sadrul 2012/10/12 22:03:49 node[apiMethod] = objectNode[apiMethod].bind(objec
Mihai Parparita -not on Chrome 2012/10/12 22:19:41 +1
lazyboy 2012/10/12 23:21:16 Cool, thanks.
+ };
+ });
Mihai Parparita -not on Chrome 2012/10/12 22:19:41 You just pass in this as an argument to forEach, a
lazyboy 2012/10/12 23:21:16 Yes, now doing this; I didn't do it b/c I was acce
shadowRoot.appendChild(this.objectNode_);
// Map attribute modifications on the <browser> tag to changes on the
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698