Issue 11139003: Move DownloadListener handling out to webview layer

Issue 11139003: Move DownloadListener handling out to webview layer (Closed)

Created:
8 years, 2 months ago by joth

Modified:
8 years, 2 months ago

Reviewers:
nilesh

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, android-webview-reviews_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Move DownloadListener handling out to webview layer Simplifies the content/ layer by not having to know about the webkit.DownloadListener interface. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161727

Patch Set 1 #

Patch Set 2 : move adapter out to gluewq #

Total comments: 2

Patch Set 3 : comment nit #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -66 lines)			Patch
M	content/public/android/java/src/org/chromium/content/browser/ContentView.java	View	1	2 chunks	+2 lines, -23 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java	View	1 2	3 chunks	+3 lines, -28 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/DownloadController.java	View		5 chunks	+4 lines, -15 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

nilesh

Nit http://codereview.chromium.org/11139003/diff/2001/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java File content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java (right): http://codereview.chromium.org/11139003/diff/2001/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java#newcode215 content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:215: // ContentViewDownloadDelegate adds support for authenticated downloads I ...

8 years, 2 months ago (2012-10-12 21:42:58 UTC) #3

joth

http://codereview.chromium.org/11139003/diff/2001/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java File content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java (right): http://codereview.chromium.org/11139003/diff/2001/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java#newcode215 content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:215: // ContentViewDownloadDelegate adds support for authenticated downloads On 2012/10/12 ...

8 years, 2 months ago (2012-10-12 23:00:58 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joth@chromium.org/11139003/6002

8 years, 2 months ago (2012-10-12 23:01:36 UTC) #5

Change committed as 161727

Expand Messages | Collapse Messages