Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1313)

Unified Diff: build/android/envsetup.sh

Issue 11137023: Remove redundant command line option. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/android/envsetup_functions.sh » ('j') | build/android/envsetup_functions.sh » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/envsetup.sh
diff --git a/build/android/envsetup.sh b/build/android/envsetup.sh
index f94ca65b7b2aff0cec095f86ac27d00ac43a62fb..fb59b23d1ccb003e24292b6f315993c8482a84b7 100755
--- a/build/android/envsetup.sh
+++ b/build/android/envsetup.sh
@@ -6,7 +6,7 @@
# Sets up environment for building Chromium on Android. It can either be
# compiled with the Android tree or using the Android SDK/NDK. To build with
-# NDK/SDK: ". build/android/envsetup.sh --sdk". Environment variable
+# NDK/SDK: ". build/android/envsetup.sh". Environment variable
# ANDROID_SDK_BUILD=1 will then be defined and used in the rest of the setup to
# specifiy build type.
@@ -22,7 +22,6 @@ fi
# Loop over args in case we add more arguments in the future.
while [ "$1" != "" ]; do
case $1 in
- -s | --sdk ) export ANDROID_SDK_BUILD=1 ; shift ;;
shashi 2012/10/15 22:29:20 Just thought that I can remove the above while loo
Yaron 2012/10/15 22:47:01 Yes, I'd prefer to remove this entirely.
* ) shift ; break ;;
esac
done
@@ -79,7 +78,7 @@ elif [[ -z "$ANDROID_BUILD_TOP" || \
echo " . build/envsetup.sh"
echo " lunch"
echo "Then try this again."
- echo "Or did you mean NDK/SDK build. Run envsetup.sh with --sdk argument."
+ echo "Or did you mean NDK/SDK build. Run envsetup.sh without any arguments."
return 1
elif [[ -n "$CHROME_ANDROID_BUILD_WEBVIEW" ]]; then
webview_build_init
« no previous file with comments | « no previous file | build/android/envsetup_functions.sh » ('j') | build/android/envsetup_functions.sh » ('J')

Powered by Google App Engine
This is Rietveld 408576698