Revert "Revert"Adding a WindowAndroidHelper class"

Revert "Revert"Adding a WindowAndroidHelper class"

This reverts the revert 2ed4f50146612690b5c183cdbe060f4c4fd9fb8a.

My change https://chromiumcodereview.appspot.com/11098008/ got reverted
due to crash on startup of chromium_testshell.

The difference from the previous CL is that TabBaseAndroidImpl constructor
now calls InitTabHelpers() and that InitTabHelpers() is now a protected instead
of private.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162237

[aurimas (slooooooooow), 2012-10-12 22:04:09]

Hey Yaron,

I fixed my previous CL. Please take a look.

Aurimas

[aurimas (slooooooooow), 2012-10-15 15:56:50]

Hello Avi,

I previous CL got reverted because I forgot to initialize the tab helpers for
the chromium_testshell. This is the same as previous CL except with the
additional call to InitTabHelpers().

Aurimas

[Avi (use Gerrit), 2012-10-15 16:34:51]

SLGTM

[aurimas (slooooooooow), 2012-10-15 20:02:05]

Hey Nilesh,

Could you take a look at this CL?

Aurimas

[nilesh, 2012-10-15 20:17:26]

LGTM

[nilesh, 2012-10-15 20:17:50]

You can also try android_fyi_dbg

[aurimas (slooooooooow), 2012-10-15 20:22:46]

Hey Ted,

Could you take a look at this CL?

Aurimas

[Ted C, 2012-10-15 20:37:34]

lgtm

[aurimas (slooooooooow), 2012-10-15 23:56:12]

Hello Brett,

Could you take a look at this CL please? It is a fixed version of my previous CL
(https://chromiumcodereview.appspot.com/11098008/).

Thanks,
Aurimas

[aurimas (slooooooooow), 2012-10-16 00:59:48]

Hello Scott,

brettw is really busy, could you take a look at this CL?

Thanks,
Aurimas

[sky, 2012-10-16 15:40:37]

What parts of this do you need me to review?

[aurimas (slooooooooow), 2012-10-16 15:46:29]

On 2012/10/16 15:40:37, sky wrote:
> What parts of this do you need me to review?

I've got LTGMs from all the subdirectories so I really need a rubber stamp
approval.

Aurimas

[sky, 2012-10-16 16:55:18]

If you've got approvals from all OWNERs, you shouldn't need me.

  -Scott

On Tue, Oct 16, 2012 at 8:46 AM,  <aurimas@chromium.org> wrote:
> On 2012/10/16 15:40:37, sky wrote:
>>
>> What parts of this do you need me to review?
>
>
> I've got LTGMs from all the subdirectories so I really need a rubber stamp
> approval.
>
> Aurimas
>
> https://chromiumcodereview.appspot.com/11137004/

[aurimas_google.com, 2012-10-16 16:57:37]

I need an owner of chrome/ because of chrome/chrome_browser_ui.gypi change.

Aurimas


On Tue, Oct 16, 2012 at 9:55 AM, Scott Violet <sky@chromium.org> wrote:

> If you've got approvals from all OWNERs, you shouldn't need me.
>
>   -Scott
>
> On Tue, Oct 16, 2012 at 8:46 AM,  <aurimas@chromium.org> wrote:
> > On 2012/10/16 15:40:37, sky wrote:
> >>
> >> What parts of this do you need me to review?
> >
> >
> > I've got LTGMs from all the subdirectories so I really need a rubber
> stamp
> > approval.
> >
> > Aurimas
> >
> > https://chromiumcodereview.appspot.com/11137004/
>

[sky, 2012-10-16 17:39:39]

LGTM

https://chromiumcodereview.appspot.com/11137004/diff/1/chrome/chrome_browser_...
File chrome/chrome_browser_ui.gypi (right):

https://chromiumcodereview.appspot.com/11137004/diff/1/chrome/chrome_browser_...
chrome/chrome_browser_ui.gypi:130:
'browser/ui/android/window_android_helper.cc',
.cc first

[aurimas (slooooooooow), 2012-10-16 17:48:05]

https://chromiumcodereview.appspot.com/11137004/diff/1/chrome/chrome_browser_...
File chrome/chrome_browser_ui.gypi (right):

https://chromiumcodereview.appspot.com/11137004/diff/1/chrome/chrome_browser_...
chrome/chrome_browser_ui.gypi:130:
'browser/ui/android/window_android_helper.cc',
On 2012/10/16 17:39:39, sky wrote:
> .cc first

Done.

[commit-bot: I haz the power, 2012-10-16 17:52:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aurimas@chromium.org/11137004/16002

[commit-bot: I haz the power, 2012-10-16 20:38:45]

Change committed as 162237