Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 11137002: Re-enable BrowserViewTest.FullScreenClearsFocus on non-Windows platforms (Closed)

Created:
8 years, 2 months ago by James Cook
Modified:
8 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Re-enable BrowserViewTest.FullScreenClearsFocus The test was originally disabled because of Windows-specific failures, but runs fine on other platforms. BUG=130327 TEST=browser_tests BrowserViewTest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162258

Patch Set 1 #

Patch Set 2 : disable windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/browser/ui/views/frame/browser_view_browsertest.cc View 1 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
James Cook
Scott, PTAL. This test got disabled everywhere but works fine on non-Windows platforms.
8 years, 2 months ago (2012-10-16 16:08:45 UTC) #1
sky
LGTM
8 years, 2 months ago (2012-10-16 17:31:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/11137002/10002
8 years, 2 months ago (2012-10-16 17:51:43 UTC) #3
commit-bot: I haz the power
8 years, 2 months ago (2012-10-16 21:42:06 UTC) #4
Change committed as 162258

Powered by Google App Engine
This is Rietveld 408576698