Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(858)

Unified Diff: ui/events/gesture_detection/velocity_tracker_unittest.cc

Issue 1112813003: Pass gfx structs by const ref (gfx::Vector2d/F) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/events/gesture_detection/velocity_tracker_unittest.cc
diff --git a/ui/events/gesture_detection/velocity_tracker_unittest.cc b/ui/events/gesture_detection/velocity_tracker_unittest.cc
index 85a1f5d98f1094d5992de3c99d66dc21625328d1..c351d593974cb135ad5321e5bb5b38bef511bbd1 100644
--- a/ui/events/gesture_detection/velocity_tracker_unittest.cc
+++ b/ui/events/gesture_detection/velocity_tracker_unittest.cc
@@ -50,7 +50,7 @@ class VelocityTrackerTest : public testing::Test {
static MockMotionEvent Sample(MotionEvent::Action action,
gfx::PointF p0,
sadrul 2015/04/29 15:09:53 This too?
a.berwal 2015/04/30 03:25:10 For gfx::PointF i have uploaded seprate patch.
TimeTicks t0,
- gfx::Vector2dF v,
+ const gfx::Vector2dF& v,
TimeDelta dt) {
const gfx::PointF p = p0 + ScaleVector2d(v, dt.InSecondsF());
return MockMotionEvent(action, t0 + dt, p.x(), p.y());
@@ -58,7 +58,7 @@ class VelocityTrackerTest : public testing::Test {
static void ApplyMovementSequence(VelocityTrackerState* state,
gfx::PointF p0,
sadrul 2015/04/29 15:09:53 ditto
a.berwal 2015/04/30 03:25:10 For gfx::PointF i have uploaded seprate patch.
- gfx::Vector2dF v,
+ const gfx::Vector2dF& v,
TimeTicks t0,
TimeDelta t,
size_t samples) {
@@ -73,7 +73,7 @@ class VelocityTrackerTest : public testing::Test {
static void ApplyMovement(VelocityTrackerState* state,
gfx::PointF p0,
sadrul 2015/04/29 15:09:53 ditto
a.berwal 2015/04/30 03:25:10 For gfx::PointF i have uploaded seprate patch.
- gfx::Vector2dF v,
+ const gfx::Vector2dF& v,
TimeTicks t0,
TimeDelta t,
size_t samples) {

Powered by Google App Engine
This is Rietveld 408576698