Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 11125004: fix uninitialized variable warning for vs2012 compilation (Closed)

Created:
8 years, 2 months ago by scottmg
Modified:
8 years, 2 months ago
Reviewers:
jamesr
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

fix uninitialized variable warning for vs2012 compilation NOTRY=true R=jamesr@chromium.org BUG=155147, 143646 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161686

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/renderer/render_thread_impl.cc View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 7 (0 generated)
scottmg
8 years, 2 months ago (2012-10-12 19:28:36 UTC) #1
jamesr
lgtm https://codereview.chromium.org/11125004/diff/1/content/renderer/render_thread_impl.cc File content/renderer/render_thread_impl.cc (right): https://codereview.chromium.org/11125004/diff/1/content/renderer/render_thread_impl.cc#newcode738 content/renderer/render_thread_impl.cc:738: base::SharedMemoryHandle mem_handle = base::SharedMemoryHandle(); can you just do ...
8 years, 2 months ago (2012-10-12 19:33:57 UTC) #2
scottmg
https://codereview.chromium.org/11125004/diff/1/content/renderer/render_thread_impl.cc File content/renderer/render_thread_impl.cc (right): https://codereview.chromium.org/11125004/diff/1/content/renderer/render_thread_impl.cc#newcode738 content/renderer/render_thread_impl.cc:738: base::SharedMemoryHandle mem_handle = base::SharedMemoryHandle(); On 2012/10/12 19:33:57, jamesr wrote: ...
8 years, 2 months ago (2012-10-12 19:35:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/11125004/1
8 years, 2 months ago (2012-10-12 19:36:41 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
8 years, 2 months ago (2012-10-13 00:07:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/11125004/1
8 years, 2 months ago (2012-10-13 00:20:57 UTC) #6
commit-bot: I haz the power
8 years, 2 months ago (2012-10-13 00:26:49 UTC) #7
Change committed as 161686

Powered by Google App Engine
This is Rietveld 408576698