Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 11125002: Add QuicFramer and friends. (Closed)

Created:
6 years, 1 month ago by Ryan Hamilton
Modified:
6 years, 1 month ago
CC:
chromium-reviews, pam+watch_chromium.org, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : unsigned char fixes #

Patch Set 3 : Moar fixes #

Patch Set 4 : MOAR #

Patch Set 5 : Moar! #

Patch Set 6 : narrowing in #

Total comments: 144

Patch Set 7 : Use memcpy to read #

Patch Set 8 : NET_EXPORT and win hash_set fixes #

Patch Set 9 : Add NET_EXPORT_PRIVATE to structs #

Patch Set 10 : Comments addressed. #

Patch Set 11 : More minor cleanup #

Patch Set 12 : Final fixes #

Patch Set 13 : Remove logging #

Total comments: 4

Patch Set 14 : Fix final comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5400 lines, -19 lines) Patch
M net/net.gyp View 2 chunks +26 lines, -0 lines 0 comments Download
A net/quic/crypto/crypto_framer.h View 1 2 3 4 5 6 7 8 9 1 chunk +106 lines, -0 lines 0 comments Download
A net/quic/crypto/crypto_framer.cc View 1 2 3 4 5 6 7 8 9 1 chunk +156 lines, -0 lines 0 comments Download
A net/quic/crypto/crypto_framer_test.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +316 lines, -0 lines 0 comments Download
A net/quic/crypto/crypto_protocol.h View 1 2 3 4 5 6 7 8 1 chunk +45 lines, -0 lines 0 comments Download
A net/quic/crypto/crypto_protocol.cc View 1 chunk +12 lines, -0 lines 0 comments Download
A net/quic/crypto/null_decrypter.h View 1 2 3 4 5 6 7 1 chunk +28 lines, -0 lines 0 comments Download
A net/quic/crypto/null_decrypter.cc View 1 2 3 4 5 6 7 8 9 1 chunk +35 lines, -0 lines 0 comments Download
A net/quic/crypto/null_decrypter_test.cc View 1 1 chunk +77 lines, -0 lines 0 comments Download
A net/quic/crypto/null_encrypter.h View 1 2 3 4 5 6 7 1 chunk +30 lines, -0 lines 0 comments Download
A net/quic/crypto/null_encrypter.cc View 1 chunk +37 lines, -0 lines 0 comments Download
A net/quic/crypto/null_encrypter_test.cc View 1 1 chunk +56 lines, -0 lines 0 comments Download
A net/quic/crypto/quic_decrypter.h View 1 2 3 4 5 6 7 1 chunk +28 lines, -0 lines 0 comments Download
A net/quic/crypto/quic_decrypter.cc View 1 chunk +21 lines, -0 lines 0 comments Download
A net/quic/crypto/quic_encrypter.h View 1 2 3 4 5 6 7 1 chunk +38 lines, -0 lines 0 comments Download
A net/quic/crypto/quic_encrypter.cc View 1 chunk +21 lines, -0 lines 0 comments Download
A + net/quic/quic_data_reader.h View 1 2 3 4 5 6 7 8 9 10 3 chunks +50 lines, -19 lines 0 comments Download
A net/quic/quic_data_reader.cc View 1 2 3 4 5 6 7 8 9 1 chunk +173 lines, -0 lines 0 comments Download
A net/quic/quic_data_writer.h View 1 2 3 4 5 6 7 8 9 1 chunk +94 lines, -0 lines 0 comments Download
A net/quic/quic_data_writer.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +69 lines, -0 lines 0 comments Download
A net/quic/quic_framer.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +214 lines, -0 lines 0 comments Download
A net/quic/quic_framer.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +784 lines, -0 lines 0 comments Download
A net/quic/quic_framer_test.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2157 lines, -0 lines 0 comments Download
A net/quic/quic_protocol.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +422 lines, -0 lines 0 comments Download
A net/quic/quic_protocol.cc View 1 2 3 4 5 6 7 8 9 1 chunk +39 lines, -0 lines 0 comments Download
A net/quic/quic_utils.h View 1 2 3 4 5 6 7 8 9 1 chunk +40 lines, -0 lines 0 comments Download
A net/quic/quic_utils.cc View 1 2 3 4 5 6 7 8 9 1 chunk +78 lines, -0 lines 0 comments Download
A net/quic/test_tools/quic_test_utils.h View 1 chunk +69 lines, -0 lines 0 comments Download
A net/quic/test_tools/quic_test_utils.cc View 1 chunk +140 lines, -0 lines 0 comments Download
A net/quic/uint128.h View 1 2 3 4 5 6 7 8 9 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Ryan Hamilton
Hi Jim, Here's the initial CL for QUIC. It's not yet *used*, but the framer, ...
6 years, 1 month ago (2012-10-12 19:08:57 UTC) #1
jar (doing other things)
Mostly a bunch of nits, and a few questions. https://codereview.chromium.org/11125002/diff/11031/net/quic/crypto/crypto_framer.cc File net/quic/crypto/crypto_framer.cc (right): https://codereview.chromium.org/11125002/diff/11031/net/quic/crypto/crypto_framer.cc#newcode26 net/quic/crypto/crypto_framer.cc:26: ...
6 years, 1 month ago (2012-10-14 23:04:38 UTC) #2
Ryan Hamilton
I think I've addressed most of your comment, albeit several with TODOs. This TODOs will ...
6 years, 1 month ago (2012-10-15 21:22:08 UTC) #3
jar (doing other things)
https://codereview.chromium.org/11125002/diff/11031/net/quic/crypto/crypto_framer_test.cc File net/quic/crypto/crypto_framer_test.cc (right): https://codereview.chromium.org/11125002/diff/11031/net/quic/crypto/crypto_framer_test.cc#newcode161 net/quic/crypto/crypto_framer_test.cc:161: } Not a big deal... but init to NULL, ...
6 years, 1 month ago (2012-10-15 23:54:31 UTC) #4
Ryan Hamilton
https://codereview.chromium.org/11125002/diff/11031/net/quic/crypto/crypto_framer_test.cc File net/quic/crypto/crypto_framer_test.cc (right): https://codereview.chromium.org/11125002/diff/11031/net/quic/crypto/crypto_framer_test.cc#newcode161 net/quic/crypto/crypto_framer_test.cc:161: } On 2012/10/15 23:54:32, jar wrote: > Not a ...
6 years, 1 month ago (2012-10-16 00:03:56 UTC) #5
Ryan Hamilton
https://codereview.chromium.org/11125002/diff/11031/net/quic/quic_framer.cc File net/quic/quic_framer.cc (right): https://codereview.chromium.org/11125002/diff/11031/net/quic/quic_framer.cc#newcode185 net/quic/quic_framer.cc:185: reader_.reset(NULL); On 2012/10/16 00:03:56, Ryan Hamilton wrote: > On ...
6 years, 1 month ago (2012-10-16 16:46:47 UTC) #6
jar (doing other things)
Please at least answer the questions (and possibly todo comments, or an upstream change), and ...
6 years, 1 month ago (2012-10-16 19:24:00 UTC) #7
Ryan Hamilton
Thanks for the review. https://codereview.chromium.org/11125002/diff/11031/net/quic/quic_framer.h File net/quic/quic_framer.h (right): https://codereview.chromium.org/11125002/diff/11031/net/quic/quic_framer.h#newcode112 net/quic/quic_framer.h:112: bool ProcessRevivedPacket(const IPEndPoint& client_address, On ...
6 years, 1 month ago (2012-10-16 19:43:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/11125002/33005
6 years, 1 month ago (2012-10-16 19:46:45 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2012-10-16 21:43:21 UTC) #10
Change committed as 162259

Powered by Google App Engine
This is Rietveld 408576698