Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 11122005: Adjust timeouts in PrimeLint. (Closed)

Created:
8 years, 2 months ago by srdjan
Modified:
8 years, 2 months ago
CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org
Visibility:
Public.

Description

Fix Issue 154553: gcl upload from within drover throws error Adjust timeouts in PrimeLint. BUG=154553 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161950

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M gcl.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/gcl_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
srdjan
8 years, 2 months ago (2012-10-12 20:50:26 UTC) #1
M-A Ruel
lgtm
8 years, 2 months ago (2012-10-12 20:52:23 UTC) #2
M-A Ruel
On 2012/10/12 20:52:23, Marc-Antoine Ruel wrote: > lgtm Updated the CL description.
8 years, 2 months ago (2012-10-12 20:53:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/srdjan@google.com/11122005/1
8 years, 2 months ago (2012-10-12 20:53:08 UTC) #4
commit-bot: I haz the power
Presubmit check for 11122005-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 2 months ago (2012-10-12 20:55:41 UTC) #5
iposva
lgtm
8 years, 2 months ago (2012-10-12 22:35:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/srdjan@google.com/11122005/1
8 years, 2 months ago (2012-10-12 22:35:39 UTC) #7
commit-bot: I haz the power
Presubmit check for 11122005-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 2 months ago (2012-10-12 22:38:13 UTC) #8
iposva
On 2012/10/12 22:38:13, I haz the power (commit-bot) wrote: > Presubmit check for 11122005-1 failed ...
8 years, 2 months ago (2012-10-12 23:06:41 UTC) #9
M-A Ruel
Looks like Stefan broke the pre submit check with his last commit.
8 years, 2 months ago (2012-10-13 00:08:19 UTC) #10
Ivan Posva
lgtm
8 years, 2 months ago (2012-10-15 20:41:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/srdjan@google.com/11122005/1
8 years, 2 months ago (2012-10-15 20:41:17 UTC) #12
commit-bot: I haz the power
8 years, 2 months ago (2012-10-15 20:44:06 UTC) #13
Change committed as 161950

Powered by Google App Engine
This is Rietveld 408576698