Use antialiasing and bitmap filtering when needed in software compositor.

Use antialiasing and bitmap filtering when needed in software compositor.

BUG=124671
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162015

[danakj, 2012-10-12 21:04:38]

http://codereview.chromium.org/11121008/diff/1/cc/CCRendererSoftware.cpp
File cc/CCRendererSoftware.cpp (right):

http://codereview.chromium.org/11121008/diff/1/cc/CCRendererSoftware.cpp#newc...
cc/CCRendererSoftware.cpp:58: return abs(f) < 1e-5f;
can you use std::numeric_limits::epsilon here?

[slavi, 2012-10-12 21:17:11]

On 2012/10/12 21:04:38, danakj wrote:
> http://codereview.chromium.org/11121008/diff/1/cc/CCRendererSoftware.cpp
> File cc/CCRendererSoftware.cpp (right):
> 
>
http://codereview.chromium.org/11121008/diff/1/cc/CCRendererSoftware.cpp#newc...
> cc/CCRendererSoftware.cpp:58: return abs(f) < 1e-5f;
> can you use std::numeric_limits::epsilon here?

Done.

[danakj, 2012-10-12 21:24:37]

http://codereview.chromium.org/11121008/diff/9001/cc/CCRendererSoftware.cpp
File cc/CCRendererSoftware.cpp (right):

http://codereview.chromium.org/11121008/diff/9001/cc/CCRendererSoftware.cpp#n...
cc/CCRendererSoftware.cpp:59: return abs(f) <
std::numeric_limits<float>::epsilon();
thanks! i think this should be std::abs() as well or it might break when we
remove webcore headers.

[aelias_OOO_until_Jul13, 2012-10-12 21:26:56]

http://codereview.chromium.org/11121008/diff/9001/cc/CCRendererSoftware.cpp
File cc/CCRendererSoftware.cpp (right):

http://codereview.chromium.org/11121008/diff/9001/cc/CCRendererSoftware.cpp#n...
cc/CCRendererSoftware.cpp:57: bool isZero(float f)
No need for this method.  You can use SkScalarNearlyZero and SkScalarNearlyEqual
from SkScalar.h.

[slavi, 2012-10-12 21:38:08]

On 2012/10/12 21:26:56, aelias wrote:
> http://codereview.chromium.org/11121008/diff/9001/cc/CCRendererSoftware.cpp
> File cc/CCRendererSoftware.cpp (right):
> 
>
http://codereview.chromium.org/11121008/diff/9001/cc/CCRendererSoftware.cpp#n...
> cc/CCRendererSoftware.cpp:57: bool isZero(float f)
> No need for this method.  You can use SkScalarNearlyZero and
SkScalarNearlyEqual
> from SkScalar.h.

Good catch =-)

I didn't notice that even though the whole point of isScaleAndTranslate is to
workaround that SkMatrix::rectStaysRect doesn't handle epsilon values well.

SkScalarNearlyZero epsilon value is a little big -- 0.000244141. For comparison,
I used 1e-5f and numeric_limits::eps is 1.19209e-07. But that will still work.

[aelias_OOO_until_Jul13, 2012-10-12 22:34:12]

lgtm

[jamesr, 2012-10-12 22:36:36]

lgtm2

[jamesr, 2012-10-12 22:36:48]

Oh whoops I wasn't on the R= line. Sorry!

[commit-bot: I haz the power, 2012-10-15 21:32:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skaslev@chromium.org/11121008/6006

[commit-bot: I haz the power, 2012-10-16 00:56:37]

Change committed as 162015