Pass the client end handle of the network-to-daemon IPC channel via handle inheritance.

Pass the client end handle of the network-to-daemon IPC channel via handle inheritance.

This CL also starts using the APIs used to create the server end of the channel when running remoting_unittests on Windows.

BUG=134694
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161651

[alexeypa (please no reviews), 2012-10-12 00:16:21]

PTAL.

[simonmorris, 2012-10-12 16:31:12]

lgtm after my comments are addressed.

http://codereview.chromium.org/11118005/diff/1/remoting/host/remoting_me2me_h...
File remoting/host/remoting_me2me_host.cc (right):

http://codereview.chromium.org/11118005/diff/1/remoting/host/remoting_me2me_h...
remoting/host/remoting_me2me_host.cc:95: // The command line switches specifying
the daemon IPC endpoint.
switches -> switch?

http://codereview.chromium.org/11118005/diff/1/remoting/host/win/unprivileged...
File remoting/host/win/unprivileged_process_delegate.cc (right):

http://codereview.chromium.org/11118005/diff/1/remoting/host/win/unprivileged...
remoting/host/win/unprivileged_process_delegate.cc:26: // could use Chrome IPC
APIs instead of connecting manually.
Both of these constants appear in more than one file. They should probably be
factored out.

http://codereview.chromium.org/11118005/diff/1/remoting/host/win/unprivileged...
remoting/host/win/unprivileged_process_delegate.cc:29: // The command line
switches specifying the daemon IPC endpoint.
switches -> switch?

http://codereview.chromium.org/11118005/diff/1/remoting/host/win/unprivileged...
remoting/host/win/unprivileged_process_delegate.cc:93: // Generate a unique name
of the channel.
of -> for

http://codereview.chromium.org/11118005/diff/1/remoting/host/win/unprivileged...
remoting/host/win/unprivileged_process_delegate.cc:151: std::string
channel_name,
std::string -> const std::string& ?

http://codereview.chromium.org/11118005/diff/1/remoting/host/win/unprivileged...
remoting/host/win/unprivileged_process_delegate.cc:170: TRUE };
This seems an unnecessarily opaque way to initialise |security_attributes|.

http://codereview.chromium.org/11118005/diff/1/remoting/host/win/unprivileged...
File remoting/host/win/unprivileged_process_delegate.h (right):

http://codereview.chromium.org/11118005/diff/1/remoting/host/win/unprivileged...
remoting/host/win/unprivileged_process_delegate.h:53: bool
CreateConnectedIpcChannel(const std::string channel_name,
string -> string& ?

http://codereview.chromium.org/11118005/diff/1/remoting/host/win/unprivileged...
remoting/host/win/unprivileged_process_delegate.h:67: // The server end of the
IPC channel used to commonicate to the worker
commonicate -> communicate

http://codereview.chromium.org/11118005/diff/1/remoting/host/win/worker_proce...
File remoting/host/win/worker_process_launcher.cc (right):

http://codereview.chromium.org/11118005/diff/1/remoting/host/win/worker_proce...
remoting/host/win/worker_process_launcher.cc:256: this,
&Core::RecordSuccessfullLaunch);
Successfull -> Successful

http://codereview.chromium.org/11118005/diff/1/remoting/host/win/wts_session_...
File remoting/host/win/wts_session_process_delegate.cc (right):

http://codereview.chromium.org/11118005/diff/1/remoting/host/win/wts_session_...
remoting/host/win/wts_session_process_delegate.cc:117: // The server end of the
IPC channel used to commonicate to the worker
commonicate -> communicate

[alexeypa (please no reviews), 2012-10-12 18:44:39]

https://chromiumcodereview.appspot.com/11118005/diff/1/remoting/host/remoting...
File remoting/host/remoting_me2me_host.cc (right):

https://chromiumcodereview.appspot.com/11118005/diff/1/remoting/host/remoting...
remoting/host/remoting_me2me_host.cc:95: // The command line switches specifying
the daemon IPC endpoint.
On 2012/10/12 16:31:13, simonmorris wrote:
> switches -> switch?

Done.

https://chromiumcodereview.appspot.com/11118005/diff/1/remoting/host/win/unpr...
File remoting/host/win/unprivileged_process_delegate.cc (right):

https://chromiumcodereview.appspot.com/11118005/diff/1/remoting/host/win/unpr...
remoting/host/win/unprivileged_process_delegate.cc:26: // could use Chrome IPC
APIs instead of connecting manually.
On 2012/10/12 16:31:13, simonmorris wrote:
> Both of these constants appear in more than one file. They should probably be
> factored out.

Done.

https://chromiumcodereview.appspot.com/11118005/diff/1/remoting/host/win/unpr...
remoting/host/win/unprivileged_process_delegate.cc:29: // The command line
switches specifying the daemon IPC endpoint.
On 2012/10/12 16:31:13, simonmorris wrote:
> switches -> switch?

Done.

https://chromiumcodereview.appspot.com/11118005/diff/1/remoting/host/win/unpr...
remoting/host/win/unprivileged_process_delegate.cc:93: // Generate a unique name
of the channel.
On 2012/10/12 16:31:13, simonmorris wrote:
> of -> for

Done.

https://chromiumcodereview.appspot.com/11118005/diff/1/remoting/host/win/unpr...
remoting/host/win/unprivileged_process_delegate.cc:151: std::string
channel_name,
On 2012/10/12 16:31:13, simonmorris wrote:
> std::string -> const std::string& ?

Done.

https://chromiumcodereview.appspot.com/11118005/diff/1/remoting/host/win/unpr...
remoting/host/win/unprivileged_process_delegate.cc:170: TRUE };
On 2012/10/12 16:31:13, simonmorris wrote:
> This seems an unnecessarily opaque way to initialise |security_attributes|.

Done.

https://chromiumcodereview.appspot.com/11118005/diff/1/remoting/host/win/unpr...
File remoting/host/win/unprivileged_process_delegate.h (right):

https://chromiumcodereview.appspot.com/11118005/diff/1/remoting/host/win/unpr...
remoting/host/win/unprivileged_process_delegate.h:53: bool
CreateConnectedIpcChannel(const std::string channel_name,
On 2012/10/12 16:31:13, simonmorris wrote:
> string -> string& ?

Done.

https://chromiumcodereview.appspot.com/11118005/diff/1/remoting/host/win/unpr...
remoting/host/win/unprivileged_process_delegate.h:67: // The server end of the
IPC channel used to commonicate to the worker
On 2012/10/12 16:31:13, simonmorris wrote:
> commonicate -> communicate

Done.

https://chromiumcodereview.appspot.com/11118005/diff/1/remoting/host/win/work...
File remoting/host/win/worker_process_launcher.cc (right):

https://chromiumcodereview.appspot.com/11118005/diff/1/remoting/host/win/work...
remoting/host/win/worker_process_launcher.cc:256: this,
&Core::RecordSuccessfullLaunch);
On 2012/10/12 16:31:13, simonmorris wrote:
> Successfull -> Successful

Done.

https://chromiumcodereview.appspot.com/11118005/diff/1/remoting/host/win/wts_...
File remoting/host/win/wts_session_process_delegate.cc (right):

https://chromiumcodereview.appspot.com/11118005/diff/1/remoting/host/win/wts_...
remoting/host/win/wts_session_process_delegate.cc:117: // The server end of the
IPC channel used to commonicate to the worker
On 2012/10/12 16:31:13, simonmorris wrote:
> commonicate -> communicate

Done.

[commit-bot: I haz the power, 2012-10-12 18:48:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alexeypa@chromium.org/11118005/8001

[commit-bot: I haz the power, 2012-10-12 21:07:14]

Change committed as 161651