Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 11117010: Fix gyp for type_profiler to work for make. (Closed)

Created:
8 years, 2 months ago by Dai Mikurube (NOT FULLTIME)
Modified:
8 years, 2 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, dmikurube+memory_chromium.org
Visibility:
Public.

Description

Fix gyp for type_profiler to work for make. BUG=123758, 154240 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161826

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M base/allocator/allocator.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Dai Mikurube (NOT FULLTIME)
Hi Ryan, Thank you. It is fixed by your suggestion. I made sure that it ...
8 years, 2 months ago (2012-10-12 05:17:18 UTC) #1
Ryan Sleevi
This LGTM (and not just because I suggested it :-p) Jim: The context of this ...
8 years, 2 months ago (2012-10-12 18:06:35 UTC) #2
jar (doing other things)
lgtm
8 years, 2 months ago (2012-10-14 23:05:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmikurube@chromium.org/11117010/1
8 years, 2 months ago (2012-10-15 02:32:33 UTC) #4
Dai Mikurube (NOT FULLTIME)
Thank you! Checked the "Commit" box.
8 years, 2 months ago (2012-10-15 02:32:38 UTC) #5
commit-bot: I haz the power
8 years, 2 months ago (2012-10-15 04:38:36 UTC) #6
Change committed as 161826

Powered by Google App Engine
This is Rietveld 408576698