Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Issue 11117003: Add the swap size to the PostSubBuffer trace event (Closed)

Created:
8 years, 2 months ago by danakj
Modified:
8 years, 2 months ago
Reviewers:
gman1, greggman
CC:
chromium-reviews, cc-bugs_chromium.org, backer, piman
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add the swap size to the PostSubBuffer trace event BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162213

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : command-buffer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M gpu/command_buffer/client/gles2_implementation.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
danakj
Is this the right trace to add the swap size to?
8 years, 2 months ago (2012-10-11 23:32:44 UTC) #1
danakj
On 2012/10/11 23:32:44, danakj wrote: > Is this the right trace to add the swap ...
8 years, 2 months ago (2012-10-13 01:13:18 UTC) #2
jamesr
We already have traces in the command buffer code for postSubBuffer..() and prepareTexture(), although they ...
8 years, 2 months ago (2012-10-15 17:45:13 UTC) #3
danakj
Ah, ok, moving to the command buffer code. @gman can you please take a look? ...
8 years, 2 months ago (2012-10-15 18:18:57 UTC) #4
danakj
8 years, 2 months ago (2012-10-15 18:19:09 UTC) #5
greggman
lgtm
8 years, 2 months ago (2012-10-16 17:26:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/11117003/9001
8 years, 2 months ago (2012-10-16 17:27:37 UTC) #7
commit-bot: I haz the power
8 years, 2 months ago (2012-10-16 19:35:24 UTC) #8
Change committed as 162213

Powered by Google App Engine
This is Rietveld 408576698