Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Unified Diff: chrome/browser/extensions/api/notification/notification_apitest.cc

Issue 11116016: Hook up API to notification_ui_manager. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: asargent review suggestion Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/notification/notification_apitest.cc
diff --git a/chrome/browser/extensions/api/notification/notification_apitest.cc b/chrome/browser/extensions/api/notification/notification_apitest.cc
index 5956e0fed2d6a54bbcde654de2eeb021e8382af0..f5b4c056cb66ff0dc18468de9eeb8bb415e39a9f 100644
--- a/chrome/browser/extensions/api/notification/notification_apitest.cc
+++ b/chrome/browser/extensions/api/notification/notification_apitest.cc
@@ -17,7 +17,7 @@ class NotificationApiTest : public PlatformAppApiTest {
} // namespace
-IN_PROC_BROWSER_TEST_F(NotificationApiTest, TestNothing) {
+IN_PROC_BROWSER_TEST_F(NotificationApiTest, TestNormalNotification) {
scoped_refptr<extensions::NotificationShowFunction>
notification_show_function(new extensions::NotificationShowFunction());
scoped_refptr<Extension> empty_extension(utils::CreateEmptyExtension());
@@ -27,7 +27,14 @@ IN_PROC_BROWSER_TEST_F(NotificationApiTest, TestNothing) {
scoped_ptr<base::Value> result(utils::RunFunctionAndReturnSingleResult(
notification_show_function,
- "[{\"text\": \"Check out Cirque du Soleil\"}]",
+ "[{"
+ "\"iconUrl\": \"http://www.google.com/intl/en/chrome/assets/"
+ "common/images/chrome_logo_2x.png\","
+ "\"title\": \"Attention!\","
+ "\"message\": \"Check out Cirque du Soleil\","
+ "\"replaceId\": \"12345678\""
+ "}]",
browser(), utils::NONE));
- ASSERT_EQ(base::Value::TYPE_BOOLEAN, result->GetType());
+
+ ASSERT_EQ(base::Value::TYPE_DICTIONARY, result->GetType());
}

Powered by Google App Engine
This is Rietveld 408576698