Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 11116013: [content shell] allow universal access from file URLs in layout tests (Closed)

Created:
8 years, 2 months ago by jochen (gone - plz use gerrit)
Modified:
8 years, 2 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

[content shell] allow universal access from file URLs in layout tests BUG=111316 TEST=compositing/iframes/iframe-in-composited-layer.html does not time out Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161634

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M chrome/browser/ui/startup/bad_flags_prompt.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/shell/shell_main_delegate.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jochen (gone - plz use gerrit)
plz review compare http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/WebPreferences.cpp#L103
8 years, 2 months ago (2012-10-12 13:25:04 UTC) #1
jochen (gone - plz use gerrit)
Justin, fyi - another scary command line option, although not really worse than --allow-file-access-from files ...
8 years, 2 months ago (2012-10-12 13:25:43 UTC) #2
jochen (gone - plz use gerrit)
On 2012/10/12 13:25:43, jochen wrote: > Justin, fyi - another scary command line option, although ...
8 years, 2 months ago (2012-10-12 13:45:09 UTC) #3
jschuh
On 2012/10/12 13:45:09, jochen wrote: > On 2012/10/12 13:25:43, jochen wrote: > > Justin, fyi ...
8 years, 2 months ago (2012-10-12 13:48:43 UTC) #4
jam
lgtm
8 years, 2 months ago (2012-10-12 17:16:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/11116013/7001
8 years, 2 months ago (2012-10-12 17:46:17 UTC) #6
commit-bot: I haz the power
8 years, 2 months ago (2012-10-12 19:10:23 UTC) #7
Change committed as 161634

Powered by Google App Engine
This is Rietveld 408576698