Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(972)

Unified Diff: scripts/slave/annotated_run.py

Issue 1111413005: Some changes to allow recipes and modules to live noncentrally (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Little bitty cleanup Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/annotated_run.py
diff --git a/scripts/slave/annotated_run.py b/scripts/slave/annotated_run.py
index b030c8be12d214e9af9a9bd7aed7b96f4c1dfa13..825e966c6c6d1dcf087ee8150b305760b0344765 100755
--- a/scripts/slave/annotated_run.py
+++ b/scripts/slave/annotated_run.py
@@ -314,8 +314,10 @@ def main(argv=None):
opts, _ = get_args(argv)
stream = annotator.StructuredAnnotationStream()
+ loader = recipe_loader.ModuleLoader()
- ret = run_steps(stream, opts.build_properties, opts.factory_properties)
+ ret = run_steps(stream, opts.build_properties, opts.factory_properties,
+ loader)
return ret.status_code
@@ -358,7 +360,7 @@ def get_recipe_properties(factory_properties, build_properties):
def run_steps(stream, build_properties, factory_properties,
- test_data=recipe_test_api.DisabledTestData()):
+ loader, test_data=recipe_test_api.DisabledTestData()):
"""Returns a tuple of (status_code, steps_ran).
Only one of these values will be set at a time. This is mainly to support the
@@ -423,9 +425,9 @@ def run_steps(stream, build_properties, factory_properties,
s.step_log_end('run_recipe')
try:
- recipe_module = recipe_loader.load_recipe(recipe)
+ recipe_module = recipe_loader.load_recipe(recipe, loader)
iannucci 2015/05/05 23:35:59 erm... shouldn't this be recipe_module = loade
luqui 2015/05/06 22:18:39 Done.
stream.emit('Running recipe with %s' % (properties,))
- api = recipe_loader.create_recipe_api(recipe_module.DEPS,
+ api = recipe_loader.create_recipe_api(recipe_module.LOADED_DEPS,
engine,
test_data)
steps = recipe_module.GenSteps

Powered by Google App Engine
This is Rietveld 408576698