tests/presubmit_unittest.py - Issue 11114005: implement per-file OWNERS support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/presubmit_unittest.py

Issue 11114005: implement per-file OWNERS support (Closed) Base URL: https://git.chromium.org/chromium/tools/depot_tools.git@master

Patch Set: update w/ more review feedback Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/presubmit_unittest.py

diff --git a/tests/presubmit_unittest.py b/tests/presubmit_unittest.py

index 24890e8c586f6d61c70d568adbff4db6ac510d7e..cf449dcc83fe0569926c41c6e786233c06cf901d 100755

--- a/tests/presubmit_unittest.py

+++ b/tests/presubmit_unittest.py

@@ -748,7 +748,7 @@ def CheckChangeOnCommit(input_api, output_api):

expected_result1 = ['1', '2']

expected_result2 = ['a', 'b', 'c']

script = self.presubmit_tryslave_project % (

- repr('foo'), repr(expected_result1), repr(expected_result2))

+ repr('foo'), repr(expected_result1), repr(expected_result2))

self.assertEqual(

expected_result1, executer.ExecPresubmitScript(script, '', 'foo',

change))

@@ -868,8 +868,8 @@ class InputApiUnittest(PresubmitTestsBase):

'LocalToDepotPath',

'PresubmitLocalPath', 'ReadFile', 'RightHandSideLines', 'ServerPaths',

'basename', 'cPickle', 'cStringIO', 'canned_checks', 'change', 'environ',

- 'host_url', 'is_committing', 'json', 'logging', 'marshal', 'os_listdir',

- 'os_walk',

+ 'glob', 'host_url', 'is_committing', 'json', 'logging', 'marshal',

+ 'os_listdir', 'os_walk',

'os_path', 'owners_db', 'pickle', 'platform', 'python_executable', 're',

'rietveld', 'subprocess', 'tbr', 'tempfile', 'time', 'traceback',

'unittest', 'urllib2', 'version', 'verbose',

« no previous file with comments | « tests/owners_unittest.py ('k') | no next file » | no next file with comments »