presubmit_support.py - Issue 11114005: implement per-file OWNERS support - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(135)

My Issues | Starred Open | Closed | All

Unified Diff: presubmit_support.py

Issue 11114005: implement per-file OWNERS support (Closed) Base URL: https://git.chromium.org/chromium/tools/depot_tools.git@master

Patch Set: update w/ more review feedback Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « owners.py ('k') | testing_support/filesystem_mock.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: presubmit_support.py

diff --git a/presubmit_support.py b/presubmit_support.py

index b1fdcb2fb7f1b527674650983b52a77a79154e56..0989fd1662ffea28b6bd09b4c9798711995ea4b4 100755

--- a/presubmit_support.py

+++ b/presubmit_support.py

@@ -238,6 +238,7 @@ class InputApi(object):

self.basename = os.path.basename

self.cPickle = cPickle

self.cStringIO = cStringIO

+ self.glob = glob.glob

self.json = json

self.logging = logging.getLogger('PRESUBMIT')

self.os_listdir = os.listdir

@@ -269,7 +270,7 @@ class InputApi(object):

# TODO(dpranke): figure out a list of all approved owners for a repo

# in order to be able to handle wildcard OWNERS files?

self.owners_db = owners.Database(change.RepositoryRoot(),

- fopen=file, os_path=self.os_path)

+ fopen=file, os_path=self.os_path, glob=self.glob)

self.verbose = verbose

def PresubmitLocalPath(self):

« no previous file with comments | « owners.py ('k') | testing_support/filesystem_mock.py » ('j') | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698