Issue 11113004: Do not consume keys for DISABLE_CAPS_LOCK when caps lock is off.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11113004: Do not consume keys for DISABLE_CAPS_LOCK when caps lock is off. (Closed)

Created:
8 years, 2 months ago by mazda

Modified:
8 years, 2 months ago

Reviewers:
Yusuke Sato, Daniel Erat

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Do not consume keys for DISABLE_CAPS_LOCK when caps lock is off. DISABLE_CAPS_LOCK is invoked with Shift keyup and should not be consumed. Otherwise the Shift keyup event is not sent to the renderer for tabbed web pages. BUG=155434 TEST=Manually check Shift keyup event is generated. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162236

Patch Set 1 #

Patch Set 2 : Changeded Shift key to be consumed when caps lock is turned on #

Patch Set 3 : add test #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -2 lines)			Patch
	M	ash/accelerators/accelerator_controller.cc	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
	M	ash/accelerators/accelerator_controller_unittest.cc	View	1 2	1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Daniel Erat

lgtm Sorry, I somehow missed the initial request -- I blame perf. :-) Thanks for ...

8 years, 2 months ago (2012-10-16 17:24:36 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mazda@chromium.org/11113004/5001

8 years, 2 months ago (2012-10-16 17:47:37 UTC) #7

Change committed as 162236

Expand Messages | Collapse Messages