Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2133)

Unified Diff: content/renderer/pepper/pepper_in_process_router.cc

Issue 11112004: Bug fix: in process router should not expect msg->is_sync (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/pepper/pepper_in_process_router.cc
diff --git a/content/renderer/pepper/pepper_in_process_router.cc b/content/renderer/pepper/pepper_in_process_router.cc
index 4529ca9755d3db044d58916080d2b6e2253950f3..5bcc8c7c588c9bb200c06cc4471f2ea4500afa55 100644
--- a/content/renderer/pepper/pepper_in_process_router.cc
+++ b/content/renderer/pepper/pepper_in_process_router.cc
@@ -87,8 +87,8 @@ bool PepperInProcessRouter::SendToHost(IPC::Message* msg) {
bool PepperInProcessRouter::SendToPlugin(IPC::Message* msg) {
scoped_ptr<IPC::Message> message(msg);
- if (msg->is_sync()) {
- CHECK(IPC::SyncMessage::IsMessageReplyTo(*message, pending_message_id_));
+ CHECK(!msg->is_sync());
+ if (IPC::SyncMessage::IsMessageReplyTo(*message, pending_message_id_)) {
if (!msg->is_reply_error())
reply_result_ = reply_deserializer_->SerializeOutputParameters(*message);
} else {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698