Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: webkit/database/databases_table_unittest.cc

Issue 11111021: Remove ref counting on sql::ErrorDelegate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Changes as requested Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/appcache/appcache_database_unittest.cc ('k') | webkit/database/quota_table_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/database/databases_table_unittest.cc
diff --git a/webkit/database/databases_table_unittest.cc b/webkit/database/databases_table_unittest.cc
index 62b56ca6d463cc43bfd1e72295799b5fbd824758..1849c6a8ddb68ea544b53dea9824b6e01fb148da 100644
--- a/webkit/database/databases_table_unittest.cc
+++ b/webkit/database/databases_table_unittest.cc
@@ -13,14 +13,17 @@ namespace {
class TestErrorDelegate : public sql::ErrorDelegate {
public:
+ TestErrorDelegate() {}
+ virtual ~TestErrorDelegate() {}
+
virtual int OnError(int error,
sql::Connection* connection,
sql::Statement* stmt) OVERRIDE {
return error;
}
- protected:
- virtual ~TestErrorDelegate() {}
+ private:
+ DISALLOW_COPY_AND_ASSIGN(TestErrorDelegate);
};
} // namespace
@@ -46,8 +49,7 @@ TEST(DatabasesTableTest, TestIt) {
sql::Connection db;
// Set an error delegate that will make all operations return false on error.
- scoped_refptr<TestErrorDelegate> error_delegate(new TestErrorDelegate());
- db.set_error_delegate(error_delegate);
+ db.set_error_delegate(new TestErrorDelegate());
// Initialize the temp dir and the 'Databases' table.
EXPECT_TRUE(db.OpenInMemory());
« no previous file with comments | « webkit/appcache/appcache_database_unittest.cc ('k') | webkit/database/quota_table_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698