Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Side by Side Diff: sql/diagnostic_error_delegate.h

Issue 11111021: Remove ref counting on sql::ErrorDelegate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Changes as requested Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « sql/connection.cc ('k') | sql/sqlite_features_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef SQL_DIAGNOSTIC_ERROR_DELEGATE_H_ 5 #ifndef SQL_DIAGNOSTIC_ERROR_DELEGATE_H_
6 #define SQL_DIAGNOSTIC_ERROR_DELEGATE_H_ 6 #define SQL_DIAGNOSTIC_ERROR_DELEGATE_H_
7 7
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "base/metrics/histogram.h" 9 #include "base/metrics/histogram.h"
10 #include "sql/connection.h" 10 #include "sql/connection.h"
11 #include "sql/sql_export.h" 11 #include "sql/sql_export.h"
12 12
13 namespace sql { 13 namespace sql {
14 14
15 // This class handles the exceptional sqlite errors that we might encounter 15 // This class handles the exceptional sqlite errors that we might encounter
16 // if for example the db is corrupted. Right now we just generate a UMA 16 // if for example the db is corrupted. Right now we just generate a UMA
17 // histogram for release and an assert for debug builds. 17 // histogram for release and an assert for debug builds.
18 // 18 //
19 // Why is it a template you ask? well, that is a funny story. The histograms 19 // Why is it a template you ask? well, that is a funny story. The histograms
20 // need to be singletons that is why they are always static at the function 20 // need to be singletons that is why they are always static at the function
21 // scope, but we cannot use the Singleton class because they are not default 21 // scope, but we cannot use the Singleton class because they are not default
22 // constructible. The template parameter makes the compiler to create unique 22 // constructible. The template parameter makes the compiler to create unique
23 // classes that don't share the same static variable. 23 // classes that don't share the same static variable.
24 template <class UniqueT> 24 template <class UniqueT>
25 class DiagnosticErrorDelegate : public ErrorDelegate { 25 class DiagnosticErrorDelegate : public ErrorDelegate {
26 public: 26 public:
27 DiagnosticErrorDelegate() {}
28 virtual ~DiagnosticErrorDelegate() {}
27 29
28 virtual int OnError(int error, Connection* connection, 30 virtual int OnError(int error, Connection* connection,
29 Statement* stmt) { 31 Statement* stmt) {
30 LOG(ERROR) << "sqlite error " << error 32 LOG(ERROR) << "sqlite error " << error
31 << ", errno " << connection->GetLastErrno() 33 << ", errno " << connection->GetLastErrno()
32 << ": " << connection->GetErrorMessage(); 34 << ": " << connection->GetErrorMessage();
33 RecordErrorInHistogram(error); 35 RecordErrorInHistogram(error);
34 return error; 36 return error;
35 } 37 }
36 38
37 private: 39 private:
38 static void RecordErrorInHistogram(int error) { 40 static void RecordErrorInHistogram(int error) {
39 // Trim off the extended error codes. 41 // Trim off the extended error codes.
40 error &= 0xff; 42 error &= 0xff;
41 43
42 // The histogram values from sqlite result codes go currently from 1 to 44 // The histogram values from sqlite result codes go currently from 1 to
43 // 26 currently but 50 gives them room to grow. 45 // 26 currently but 50 gives them room to grow.
44 UMA_HISTOGRAM_ENUMERATION(UniqueT::name(), error, 50); 46 UMA_HISTOGRAM_ENUMERATION(UniqueT::name(), error, 50);
45 } 47 }
48
49 DISALLOW_COPY_AND_ASSIGN(DiagnosticErrorDelegate);
46 }; 50 };
47 51
48 } // namespace sql 52 } // namespace sql
49 53
50 #endif // SQL_DIAGNOSTIC_ERROR_DELEGATE_H_ 54 #endif // SQL_DIAGNOSTIC_ERROR_DELEGATE_H_
OLDNEW
« no previous file with comments | « sql/connection.cc ('k') | sql/sqlite_features_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698