Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: content/browser/browser_plugin/browser_plugin_embedder.cc

Issue 11111020: <browser>: Always read <browser>.src attribute from <object>.src. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments from creis@ Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_plugin/browser_plugin_embedder.cc
diff --git a/content/browser/browser_plugin/browser_plugin_embedder.cc b/content/browser/browser_plugin/browser_plugin_embedder.cc
index 3f001aee203f44361c98782ccae3a7e2e5e4086a..7adbe2b7cde5dd83c8d7499a108d040375f609c9 100644
--- a/content/browser/browser_plugin/browser_plugin_embedder.cc
+++ b/content/browser/browser_plugin/browser_plugin_embedder.cc
@@ -123,12 +123,13 @@ void BrowserPluginEmbedder::NavigateGuest(
WebContentsImpl* guest_web_contents =
static_cast<WebContentsImpl*>(guest->GetWebContents());
- // We ignore loading empty urls in web_contents.
+ // We do not load empty urls in web_contents.
// If a guest sets empty src attribute after it has navigated to some
- // non-empty page, the action is considered no-op.
- // TODO(lazyboy): The js shim for browser-plugin might need to reflect empty
- // src ignoring in the shadow DOM element: http://crbug.com/149001.
+ // non-empty page, the action is considered no-op. This empty src navigation
+ // should never be sent to BrowserPluginEmbedder (browser process).
+ DCHECK(!src.empty());
if (!src.empty()) {
+ // TODO(creis): Check the validity of the URL: http://crbug.com/139397.
guest_web_contents->GetController().LoadURL(url,
Referrer(),
PAGE_TRANSITION_AUTO_SUBFRAME,

Powered by Google App Engine
This is Rietveld 408576698