Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4582)

Unified Diff: chrome/browser/autofill/DEPS

Issue 11111018: Clean up DEPS file post Avi's recent changes to use (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge LKGR Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/autofill/autofill_external_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autofill/DEPS
diff --git a/chrome/browser/autofill/DEPS b/chrome/browser/autofill/DEPS
index 0fb9b536316bfb93800fd0840c0f7ca74e99909c..bafff1067ea641c91068ecd5be365efdb0a7af0f 100644
--- a/chrome/browser/autofill/DEPS
+++ b/chrome/browser/autofill/DEPS
@@ -11,23 +11,9 @@ include_rules = [
# Components-like DEPS above go here.
"+third_party/libphonenumber", # For phone number i18n.
- # TODO(joi): Bring this list to zero.
- #
- # Do not add to the list of temporarily-allowed dependencies below,
- # and please do not introduce more #includes of these files.
-
- # Moving to api
+ # TODO(joi): May be able to remove this if PKS is moved to c/b/api.
"!chrome/browser/profiles/profile_keyed_service.h",
- # Will go when PersonalDataManagerFactory moves to c/b/configuration.
- "!chrome/browser/profiles/profile_dependency_manager.h",
- "!chrome/browser/profiles/profile_keyed_service_factory.h",
-
- "!chrome/browser/ui/tab_contents/tab_contents.h",
-
- # Do not add to the list of temporarily-allowed dependencies above,
- # and please do not introduce more #includes of these files.
-
# TODO(akalin): Remove this dependency.
"!sync/util/data_encryption_win.h",
]
@@ -52,12 +38,15 @@ specific_include_rules = {
"!chrome/browser/ui/browser_tabstrip.h",
"!chrome/browser/ui/browser_window.h",
"!chrome/browser/ui/tab_contents/tab_autofill_manager_delegate.h",
+ "!chrome/browser/ui/tab_contents/tab_contents.h",
"!chrome/browser/ui/tab_contents/test_tab_contents.h",
],
- # TODO(joi): Get rid of the need for this by moving
- # PersonalDataManagerFactory to chrome/browser/configuration.
- 'personal_data_manager_factory\.cc': [
+ # TODO(joi): May be able to get rid of the need for this by moving
+ # PersonalDataManagerFactory to chrome/browser/profiles.
+ 'personal_data_manager_factory\.(h|cc)': [
+ "!chrome/browser/profiles/profile_dependency_manager.h",
+ "!chrome/browser/profiles/profile_keyed_service_factory.h",
"!chrome/browser/profiles/profile.h",
"!chrome/browser/webdata/web_data_service_factory.h",
],
« no previous file with comments | « no previous file | chrome/browser/autofill/autofill_external_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698