Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 11111004: Remove all callers of WebFrame::frameForEnteredContext (Closed)

Created:
8 years, 2 months ago by abarth-chromium
Modified:
8 years, 2 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, mihaip-chromium-reviews_chromium.org, jam, samarth, sreeram, apatrick_chromium, gideonwald, dominich, Aaron Boodman, David Black, Shishir, darin-cc_chromium.org, Jered
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Remove all callers of WebFrame::frameForEnteredContext Having both frameForEnteredContext and frameForCurrentContext in the API is too confusing. Code seems to randomly pick one or the other to call. Almost everyone wants to call frameForCurrentContext, so this patch removes all the callers of frameForEnteredContext. Soon we'll remove frameForEnteredContext from the API entirely. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161521

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M chrome/renderer/external_extension.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/searchbox/searchbox_extension.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/gpu_benchmarking_extension.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
abarth-chromium
8 years, 2 months ago (2012-10-11 23:32:56 UTC) #1
abarth-chromium
8 years, 2 months ago (2012-10-11 23:44:24 UTC) #2
jamesr
content/renderer lgtm. +cc nduca/dtu as FYI
8 years, 2 months ago (2012-10-11 23:46:09 UTC) #3
sreeram
lgtm
8 years, 2 months ago (2012-10-11 23:49:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/11111004/1
8 years, 2 months ago (2012-10-11 23:51:58 UTC) #5
commit-bot: I haz the power
Presubmit check for 11111004-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 2 months ago (2012-10-11 23:52:02 UTC) #6
Charlie Reis
Agreed, this seems reasonable. Most actions probably care about which frame JS is currently inside ...
8 years, 2 months ago (2012-10-11 23:52:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/11111004/1
8 years, 2 months ago (2012-10-11 23:55:53 UTC) #8
commit-bot: I haz the power
Presubmit check for 11111004-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 2 months ago (2012-10-11 23:55:56 UTC) #9
abarth-chromium
I guess I'm missing an OWNER for chrome/renderer
8 years, 2 months ago (2012-10-11 23:58:54 UTC) #10
brettw
lgtm
8 years, 2 months ago (2012-10-12 04:29:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/11111004/1
8 years, 2 months ago (2012-10-12 04:34:44 UTC) #12
commit-bot: I haz the power
8 years, 2 months ago (2012-10-12 07:02:50 UTC) #13
Change committed as 161521

Powered by Google App Engine
This is Rietveld 408576698