Issue 11108019: linux: Crash browser on too-big messages to zygote.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11108019: linux: Crash browser on too-big messages to zygote. (Closed)

Created:
8 years, 2 months ago by Daniel Erat

Modified:
8 years, 2 months ago

Reviewers:
agl, willchan no longer on Chromium, piman

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

linux: Crash browser on too-big messages to zygote. This adds CHECKs to the browser if it attempts to send a message to the zygote that exceeds the maximum message size (which causes an EMSGSIZE error in the zygote) or that contains too many file descriptors. I'm hoping that this will help make the source of the problem more apparent when we hit the message size limit, which we appear to have done multiple times (it was originally 1 KB and is now 2 KB). BUG=154409 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161645

Patch Set 1 #

Patch Set 2 : update CHECKs #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -20 lines)			Patch
M	base/posix/unix_domain_socket.h	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	base/posix/unix_domain_socket.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	content/browser/zygote_host/zygote_host_impl_linux.h	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	content/browser/zygote_host/zygote_host_impl_linux.cc	View	1	6 chunks	+22 lines, -14 lines	0 comments	Download
M	content/common/zygote_commands_linux.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/zygote/zygote_linux.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/11108019/2001

8 years, 2 months ago (2012-10-12 17:23:13 UTC) #4

Change committed as 161645

Expand Messages | Collapse Messages