Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 11106019: PluginResource: Avoid having two sets of similar methods for talking with browser and renderer. (Closed)

Created:
8 years, 2 months ago by yzshen1
Modified:
8 years, 2 months ago
Reviewers:
raymes
CC:
chromium-reviews
Visibility:
Public.

Description

PluginResource: Avoid having two sets of similar methods for talking with browser and renderer. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162066

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -88 lines) Patch
M ppapi/proxy/file_chooser_resource.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/flash_device_id_resource.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ppapi/proxy/flash_font_file_resource.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/proxy/flash_resource.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/gamepad_resource.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ppapi/proxy/plugin_resource.h View 5 chunks +20 lines, -41 lines 0 comments Download
M ppapi/proxy/plugin_resource.cc View 2 chunks +17 lines, -30 lines 0 comments Download
M ppapi/proxy/printing_resource.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ppapi/proxy/websocket_resource.cc View 5 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
yzshen1
Hi, Raymes. Would you please take a look? Thanks!
8 years, 2 months ago (2012-10-12 18:03:32 UTC) #1
raymes
lgtm thanks!
8 years, 2 months ago (2012-10-15 23:11:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/11106019/1
8 years, 2 months ago (2012-10-15 23:53:10 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 2 months ago (2012-10-16 00:07:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/11106019/6002
8 years, 2 months ago (2012-10-16 00:36:52 UTC) #5
commit-bot: I haz the power
8 years, 2 months ago (2012-10-16 03:40:59 UTC) #6
Change committed as 162066

Powered by Google App Engine
This is Rietveld 408576698